flynx/ImageGrid
1
1
Fork 0
mirror of https://github.com/flynx/ImageGrid.git synced 2025-10-28 18:00:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'master' of github.com:flynx/ImageGrid

Browse Source
This commit is contained in:
Alex A. Naanou 2020-02-08 00:10:10 +03:00
commit 02edcfc050
1 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
ui (gen4)/features/ui-widgets.js
View File

@ -1227,6 +1227,9 @@ function(title, options){
: 'off' } }))) } : 'off' } }))) }
// XXX docs!!!
// ...do not forget to document the callback(..)...
// XXX revise...
browse.items.batch = browse.items.batch =
function(spec, callback){ function(spec, callback){
var that = this var that = this
@ -1251,11 +1254,10 @@ function(spec, callback){
var cb var cb
callback callback
&& this.dialog && this.dialog
// XXX STUB this get's us around the close event getting triggered // XXX STUB .one(..) vs. .on(..) get's us around the close
// multiple times... // event getting triggered multiple times...
// ...change to .close(..) when fixed... // ...change to .close(..) when fixed...
.one('close', cb = function(mode){ .one('close', cb = function(mode){
// XXX get the field data and pass it to the callback...
callback( callback(
// get the field-value pairs... // get the field-value pairs...
spec.reduce(function(res, e){ spec.reduce(function(res, e){
@ -1271,11 +1273,16 @@ function(spec, callback){
// but passing it here is cleaner than forcing // but passing it here is cleaner than forcing
// the user to get it via closure... // the user to get it via closure...
spec, spec,
// XXX is this the right spot for this???
mode) }) mode) })
// reset the callback on update... // reset the callback on update...
.one('update', function(){ .one('update', function(){
this.dom.off('close', cb) }) // NOTE: we need to skip the initial update or it will
// .off(..) the handler right after it got bound...
// ...this will effectively shift the .off(..) stage
// by one iteration...
// XXX feels hacky -- revise...
this.one('update', function(){
this.off('close', cb) }) })
return this } return this }