flynx/ImageGrid
1
1
Fork 0
mirror of https://github.com/flynx/ImageGrid.git synced 2025-10-29 18:30:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

notes...

Browse Source 
Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
Alex A. Naanou 2019-08-07 01:01:57 +03:00
parent c7f139249b
commit 0445f0f447
1 changed files with 1 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
ui (gen4)/lib/widget/browse2.js
View File

@ -3152,6 +3152,7 @@ var BaseBrowserPrototype = {
// do not reconstruct the ones already present... // do not reconstruct the ones already present...
// XXX should from/to/around/count be a feature of this or of .walk(..)??? // XXX should from/to/around/count be a feature of this or of .walk(..)???
// XXX render all the sections at root... (???) // XXX render all the sections at root... (???)
// XXX might be a good idea to use this.root === this instead of context.root === this
render: function(options, renderer, context){ render: function(options, renderer, context){
context = this.renderContext(context) context = this.renderContext(context)
renderer = renderer || this renderer = renderer || this
@ -4613,18 +4614,6 @@ var HTMLBrowserPrototype = {
// on render that can affect scroll position, e.g. partial // on render that can affect scroll position, e.g. partial
// render... // render...
// XXX need to trigger the setup for this from .render(..) itself... // XXX need to trigger the setup for this from .render(..) itself...
// XXX BUG: context.root === this is true for non-root containers too...
//
// to reproduce:
// dialog.collapse('B/C/D')
//
// this works fine:
// dialog.get('B/C/D').collapsed = true
// dialog.render()
//
// ...this appears to be due to .render(..) not being called
// from the root object in case #1, need more investigating...
// ...we seem to be re-rendering nested dialogs on each level...
if(context.scroll_offset){ if(context.scroll_offset){
var ref = this.focused || this.pagetop var ref = this.focused || this.pagetop
var scrolled = ref.dom.offsetParent var scrolled = ref.dom.offsetParent