flynx/ImageGrid
1
1
Fork 0
mirror of https://github.com/flynx/ImageGrid.git synced 2025-11-02 20:30:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

minor cleanup...

Browse Source 
Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
Alex A. Naanou 2014-11-11 06:21:19 +03:00
parent c26bff2864
commit 04eb7ba591
1 changed files with 2 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
ui (gen4)/viewer.js
View File

@ -894,14 +894,6 @@ actions.Actions(Client, {
// ...need something like: // ...need something like:
// Features(['feature_a', 'feature_b'], action).setup() // Features(['feature_a', 'feature_b'], action).setup()
// XXX might be a good idea to automate .setup(..)/.remove(..) and split
// it into components:
// - actions sets
// - event handlers
// - will need a standard way to reference both the action-set
// and feature from the handler... (???)
// - .config merging
// - custom setup stuff
var FeatureProto = var FeatureProto =
module.FeatureProto = { module.FeatureProto = {
tag: null, tag: null,
@ -985,20 +977,13 @@ function Feature(feature_set, obj){
} }
// XXX experimental... // XXX experimental...
// ...not sure if the global feature set is a good idea... // ...not sure if the global feature set is a good idea...
// XXX might be good to track and automate:
// - documentation and control ui
// - title
// - doc
// - ...
// - exclusivity groups -- i.e. only one from a group can be on.
// the last one wins + output error
// - priority/precedence (sort)
// - dependency and dependency precedence (sort)
// XXX if this works out might be a good idea to organize everything as // XXX if this works out might be a good idea to organize everything as
// a feature... including the Client and Viewer // a feature... including the Client and Viewer
// ...needs more thought... // ...needs more thought...
// XXX add a standard doc set...
var FeatureSet = var FeatureSet =
module.FeatureSet = { module.FeatureSet = {
setup: function(obj, lst){ setup: function(obj, lst){
@ -1036,15 +1021,6 @@ module.Features = Object.create(FeatureSet)
var PartialRibbonsActions = var PartialRibbonsActions =
module.PartialRibbonsActions = module.PartialRibbonsActions =
actions.Actions({ actions.Actions({
/*
// NOTE: this is here for documentation only, mixing-this into an
// action set will overload the original config...
config: {
'ribbon-size-screens': 5,
'ribbon-resize-threshold': 1,
},
*/
updateRibbon: ['Update partial ribbon size', updateRibbon: ['Update partial ribbon size',
function(target, w, size, threshold){ function(target, w, size, threshold){
target = target instanceof jQuery target = target instanceof jQuery