flynx/ImageGrid
1
1
Fork 0
mirror of https://github.com/flynx/ImageGrid.git synced 2025-10-30 02:40:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

notes and minor tweaking...

Browse Source 
Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
Alex A. Naanou 2019-02-20 16:30:40 +03:00
parent fe1eb53780
commit 07d6e8dba9
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ui (gen4)/lib/widget/browse2.js
View File

@ -220,7 +220,7 @@ var BaseBrowserPrototype = {
// XXX need to maintain this over item add/remove/change... // XXX need to maintain this over item add/remove/change...
// XXX Q: should we be able to add/remove/change items outside of .__list__(..)??? // XXX Q: should we be able to add/remove/change items outside of .__list__(..)???
// ...only some item updates (how .collapsed is handled) make // ...only some item updates (how .collapsed is handled) make
// since at this time -- need to think about this more // sense at this time -- need to think about this more
// carefully + strictly document the result... // carefully + strictly document the result...
item_index: null, item_index: null,
@ -307,6 +307,8 @@ var BaseBrowserPrototype = {
opts = opts || {} opts = opts || {}
// XXX revise id generation... // XXX revise id generation...
// XXX check if id already exists and complain if it
// does -- only for options.id???
var key = opts.id || JSON.stringify(value) var key = opts.id || JSON.stringify(value)
// build the item... // build the item...
@ -414,7 +416,6 @@ var BaseBrowserPrototype = {
// ...if yes how?? // ...if yes how??
// - options // - options
// - arg threading // - arg threading
// - render context
var items = this.items var items = this.items
.map(_render = function(item, i){ .map(_render = function(item, i){
return ( return (
@ -430,7 +431,6 @@ var BaseBrowserPrototype = {
item.value.render(context) item.value.render(context)
// .sublist -- nested list... // .sublist -- nested list...
: item.sublist ? : item.sublist ?
// XXX revise how the context is passed...
that.renderNested( that.renderNested(
that.renderNestedHeader(item, i, context), that.renderNestedHeader(item, i, context),
// collapsed... // collapsed...
@ -522,7 +522,7 @@ var BrowserClassPrototype = {
// - event handler signature -- pass the item + optionally render... // - event handler signature -- pass the item + optionally render...
// - keyboard handling... // - keyboard handling...
// XXX render of nested lists does not affect the parent list(s)... // XXX render of nested lists does not affect the parent list(s)...
// XXX maintain expand/collapse state of nested lists in a natural way... // ...need to render lists and items both as a whole or independently...
// XXX should this use vanilla DOM or jQuery??? // XXX should this use vanilla DOM or jQuery???
var BrowserPrototype = { var BrowserPrototype = {
__proto__: BaseBrowser.prototype, __proto__: BaseBrowser.prototype,