flynx/ImageGrid
1
1
Fork 0
mirror of https://github.com/flynx/ImageGrid.git synced 2025-10-29 18:30:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

cleanup...

Browse Source 
Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
Alex A. Naanou 2017-12-23 03:00:47 +03:00
parent 330bd865e1
commit 087ed2d4e7
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
ui (gen4)/features/collections.js
View File

@ -2237,10 +2237,6 @@ module.AutoCollections = core.ImageGridFeatures.Feature({
// //
// NOTE: if n > 1 and <n args are given then the given args will get // NOTE: if n > 1 and <n args are given then the given args will get
// passed to func with an appended title... // passed to func with an appended title...
//
// XXX can we extend actions in this manner???
// ...if the action does nothing without args yes...
// test with .loadCollection(..)
var mixedModeCollectionAction = function(func, n){ var mixedModeCollectionAction = function(func, n){
return widgets.uiDialog(function(){ return widgets.uiDialog(function(){
var args = [].slice.call(arguments) var args = [].slice.call(arguments)
@ -2252,6 +2248,8 @@ var mixedModeCollectionAction = function(func, n){
return func.call(this, ...args.concat([title])) }) return func.call(this, ...args.concat([title])) })
: func.apply(this, args) }) } : func.apply(this, args) }) }
// Like mixedModeCollectionAction(..) but will do nothing if enough args
// are given...
var collectionGetterWrapper = function(func, n){ var collectionGetterWrapper = function(func, n){
return widgets.uiDialog(function(){ return widgets.uiDialog(function(){
var args = [].slice.call(arguments) var args = [].slice.call(arguments)
@ -2262,6 +2260,9 @@ var collectionGetterWrapper = function(func, n){
return func.call(this, ...args.concat([title])) }) }) return func.call(this, ...args.concat([title])) }) })
} }
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
// XXX show collections in image metadata... (???) // XXX show collections in image metadata... (???)
// XXX might be nice to indicate if a collection is loaded -- has .data??? // XXX might be nice to indicate if a collection is loaded -- has .data???
// XXX might be nice to add collection previews to the collection list... // XXX might be nice to add collection previews to the collection list...
@ -2567,11 +2568,7 @@ var UICollectionActions = actions.Actions({
}) })
})], })],
// XXX extend the original actions instead of making new actions
// that are essentially copies...
// XXX need to add "ALL" -- might need to rework .browseCollections(..) for this... // XXX need to add "ALL" -- might need to rework .browseCollections(..) for this...
// XXX this falls into infinite recursion -- need a way to break it...
// ...need to call the func ONLY if title is not given...
// XXX also do: // XXX also do:
// .saveCollection(..) // .saveCollection(..)
// XXX EXPERIMENTAL... // XXX EXPERIMENTAL...
@ -2580,6 +2577,8 @@ var UICollectionActions = actions.Actions({
// Collection actions with collection selection... // Collection actions with collection selection...
// //
// XXX extend .saveCollection(..) and remove this...
// ...see .loadCollection(..) notes above...
// XXX should we warn the user when overwriting??? // XXX should we warn the user when overwriting???
saveAsCollection: ['Collections/$Save as collection...', saveAsCollection: ['Collections/$Save as collection...',
mixedModeCollectionAction(function(title){ mixedModeCollectionAction(function(title){