From 08acd3b6143b17ff18acf044c8bb7f600295943f Mon Sep 17 00:00:00 2001 From: "Alex A. Naanou" Date: Tue, 4 Oct 2016 05:11:14 +0300 Subject: [PATCH] updated notes... Signed-off-by: Alex A. Naanou --- ui (gen4)/doc/BUILD-NOTES | 3 +-- ui (gen4)/doc/NOTES | 14 +++++++------- ui (gen4)/features/filesystem.js | 1 - 3 files changed, 8 insertions(+), 10 deletions(-) diff --git a/ui (gen4)/doc/BUILD-NOTES b/ui (gen4)/doc/BUILD-NOTES index 9a28ee94..50a9696c 100755 --- a/ui (gen4)/doc/BUILD-NOTES +++ b/ui (gen4)/doc/BUILD-NOTES @@ -26,8 +26,7 @@ Sharp To build sharp for a specific version of node: cd ./node_modules/sharp/ - node-gyp --target=v5.7.0 rebuild # v5.7.0 is the version - # of node used in nw.js + nw-gyp rebuild --target=0.17.4 --arch=x64 Speedup loading of app diff --git a/ui (gen4)/doc/NOTES b/ui (gen4)/doc/NOTES index 4c2fd4fb..91cbe901 100755 --- a/ui (gen4)/doc/NOTES +++ b/ui (gen4)/doc/NOTES @@ -6,13 +6,13 @@ Most of the system is loaded via browser context RequireJS loader, in node/nw context node-specific stuff is loaded with a second node-enabled RequireJS instance or node require. -This is done to: - - Minimize the difference between pure browser, nw and node - versions - - Enable devtools introspection on most modules. - NOTE: his is mostly due to the inability to view the node - context in nw.js devtools, when this is resolved this - point should be revised. +The ideal solution would be to use one require that sees both the browser +and node contexts, the problem is exactly in this, the browser requirejs +does not see either node or node modules while the node require loads code +that is not visible to devtools unless it is running at that exact moment. + +Thus we are forced to use both mode requirejs loaders which may be +confusing at times. Different loaders: diff --git a/ui (gen4)/features/filesystem.js b/ui (gen4)/features/filesystem.js index 99e1bbd9..de2eec7d 100755 --- a/ui (gen4)/features/filesystem.js +++ b/ui (gen4)/features/filesystem.js @@ -2081,7 +2081,6 @@ var FileSystemWriterActions = actions.Actions({ .replace(/%I/, I) // totals... - // XXX revise... .replace(/%t/, len) .replace(/%T/, total_len)