From 0cd4f3ab1a4b24f63b3fd015cdd8745fb6a70b63 Mon Sep 17 00:00:00 2001 From: "Alex A. Naanou" Date: Tue, 9 May 2017 04:32:42 +0300 Subject: [PATCH] minor stuff... Signed-off-by: Alex A. Naanou --- ui (gen4)/features/meta.js | 4 ++-- ui (gen4)/features/ui-partial-ribbons-vdom.js | 8 ++++++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/ui (gen4)/features/meta.js b/ui (gen4)/features/meta.js index 568587db..0d794735 100755 --- a/ui (gen4)/features/meta.js +++ b/ui (gen4)/features/meta.js @@ -68,8 +68,8 @@ core.ImageGridFeatures.Feature('viewer-testing', [ //*/ // XXX EXPERIMENTAL: virtual-dom based ribbons... 'ui-partial-ribbons-vdom', - '-ui-image-marks', - '-ui-image-bookmarks', + //'-ui-image-marks', + //'-ui-image-bookmarks', '-ui-partial-ribbons', '-ui-partial-ribbons-2', //*/ diff --git a/ui (gen4)/features/ui-partial-ribbons-vdom.js b/ui (gen4)/features/ui-partial-ribbons-vdom.js index 1d157b9e..a4575dd8 100755 --- a/ui (gen4)/features/ui-partial-ribbons-vdom.js +++ b/ui (gen4)/features/ui-partial-ribbons-vdom.js @@ -489,15 +489,14 @@ object.makeConstructor('VirtualDOMRibbons', // - image update (try and avoid external edits and do it in .virtualdom) // - image size/proportions (single image view)... // - preview update... -// - marking // - shifting images/ribbons // - use .virtualdom.sync() + shadow animation instead of .ribbons.* // ...the added marker div messes up virtual-dom... // - would be nice to make this an alternative feature... // ...split out ribbon editing into a feature and do two // implementations, the original and virtualdom... +// - ranges and make marks more modular... // -// var PartialRibbonsActions = actions.Actions({ config: { @@ -559,6 +558,11 @@ module.PartialRibbons = core.ImageGridFeatures.Feature({ exclusive: ['ui-partial-ribbons'], depends: [ 'ui', + + // disabled stuff... + // XXX is this the right spot for these... + '-ui-image-marks', + '-ui-image-bookmarks', ], suggested: [ 'ui-partial-ribbons-precache',