From 0e569b6261d6385cb62f8a6e8ec19e21a96e19a7 Mon Sep 17 00:00:00 2001
From: "Alex A. Naanou" <alex.nanou@gmail.com>
Date: Wed, 20 Feb 2019 16:56:36 +0300
Subject: [PATCH] cleaning up make(..) api...

Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
---
 ui (gen4)/lib/widget/browse2.js | 21 +++++++++++++++++++--
 1 file changed, 19 insertions(+), 2 deletions(-)

diff --git a/ui (gen4)/lib/widget/browse2.js b/ui (gen4)/lib/widget/browse2.js
index 51222eed..d6c46037 100755
--- a/ui (gen4)/lib/widget/browse2.js	
+++ b/ui (gen4)/lib/widget/browse2.js	
@@ -299,18 +299,35 @@ var BaseBrowserPrototype = {
 		//
 		// 	make(value)
 		// 	make(value, options)
+		// 	make(value, func[, options])
 		// 		-> make
 		//
 		var make_called = false
 		var make = function(value, opts){
 			make_called = true
+			var args = [...arguments]
+
 			opts = opts || {}
+			// handle: make(.., func, ..)
+			opts = opts instanceof Function ?
+				{open: opts}
+				: opts
+			// handle trailing options...
+			opts = args.length > 2 ?
+				Object.assign({},
+					args.pop(),
+					opts)
+				: opts
 
 			// XXX revise id generation...
-			// XXX check if id already exists and complain if it
-			// 		does -- only for options.id???
+			// XXX these should  include the path...
 			var key = opts.id || JSON.stringify(value)
 
+			// no duplicate keys...
+			if(key in new_index){
+				throw new Error(`make(..): duplicate key "${key}": `
+					+`can't create multiple items with the same key.`) }
+
 			// build the item...
 			var item = Object.assign({}, 
 				// get the old item values...