tweaking and cleanup...

Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
Alex A. Naanou 2021-01-25 00:52:25 +03:00
parent b7b4bc7aef
commit 16d4d26870

View File

@ -870,10 +870,10 @@ var SharpActions = actions.Actions({
'cacheMetadata: "all" ...'], 'cacheMetadata: "all" ...'],
// XXX EXPERIMENTAL... // XXX EXPERIMENTAL...
// XXX if we are not careful this may result in some data loss due // XXX if we are not careful this may result in some data loss due
// to unlinking or double edits before save... // to unlinking or double edits before save...
// (REVISE!!!) // (REVISE!!!)
// XXX it is also possible to save the foreground state while the // XXX it is also possible to save the foreground state while the
// task is running... // task is running...
// this should not be destructive unless saving with the exact // this should not be destructive unless saving with the exact
// same timestamp... // same timestamp...
@ -884,7 +884,7 @@ var SharpActions = actions.Actions({
// rethink... // rethink...
// ...can we make .link() work like link-on-demand, i.e. actually // ...can we make .link() work like link-on-demand, i.e. actually
// create the link on .clear() but before that use this??? // create the link on .clear() but before that use this???
// XXX move this to filesystem??? // XXX move this to features/filesystem.js???
makeIndex: ['- File/', makeIndex: ['- File/',
core.doc` core.doc`
@ -910,26 +910,27 @@ var SharpActions = actions.Actions({
saving the changes correctly and allow the user to leave the index... saving the changes correctly and allow the user to leave the index...
`, `,
function(options={}){ function(options={}){
var that = options.linked === false ? var context =
this options.linked === false ?
: this.link() this
: this.link()
return Promise.all([ return Promise.all([
// metadata... // metadata...
options.metadata !== false options.metadata !== false
&& ((options.metadata == 'full' && ((options.metadata == 'full'
&& that.readAllMetadata) ? && context.readAllMetadata) ?
// full (slow)... // full (slow)...
that.readAllMetadata() context.readAllMetadata()
// partial (fast)... // partial (fast)...
: (that.cacheAllMetadata : (context.cacheAllMetadata
&& that.cacheAllMetadata())), && context.cacheAllMetadata())),
// previews... // previews...
options.previews !== false options.previews !== false
&& that.makePreviews && context.makePreviews
&& that.makePreviews(), && context.makePreviews(),
// save... // save...
]).then(function(){ ]).then(function(){
that.saveIndex() }) }], context.saveIndex() }) }],
}) })