flynx/ImageGrid
1
1
Fork 0
mirror of https://github.com/flynx/ImageGrid.git synced 2025-10-30 19:00:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

some cleanup and docs...

Browse Source 
Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
Alex A. Naanou 2014-12-08 15:04:50 +03:00
parent 05450f261d
commit 21763f4ee9
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
ui (gen4)/lib/features.js
View File

@ -209,12 +209,12 @@ module.FeatureSet = {
// element // element
// 2) remove the duplicate features except fot the first // 2) remove the duplicate features except fot the first
// occurance // occurance
// 3) repeat 1 and 2 for a second time to cover 2'nd gen
// dependencies...
// //
// NOTE: recursice dependency expansion is not needed here as if // NOTE: recursice dependency expansion is not needed here as if
// a dependency is not included in the list then it is not // a dependency is not included in the list then it is not
// needed... // needed...
// their dependencies to be sorted, and if that does not work
// we can give up...
// NOTE: stage 2 is done later when filtering the list... // NOTE: stage 2 is done later when filtering the list...
// NOTE: if dependency errors/conflicts exist this will break at // NOTE: if dependency errors/conflicts exist this will break at
// the next step. // the next step.
@ -357,8 +357,6 @@ module.FeatureSet = {
} }
}, },
// XXX might be good to give better reasoning/classification to
// dependency errors...
setup: function(obj, lst){ setup: function(obj, lst){
lst = lst.constructor !== Array ? [lst] : lst lst = lst.constructor !== Array ? [lst] : lst
var features = this.buildFeatureList(obj, lst) var features = this.buildFeatureList(obj, lst)
@ -372,13 +370,19 @@ module.FeatureSet = {
// build a report... // build a report...
var report = [] var report = []
// missing deps...
Object.keys(m).forEach(function(k){ Object.keys(m).forEach(function(k){
report.push(k + ': missing but required by:\n ' + m[k].join(', ')) report.push(k + ': missing but required by:\n ' + m[k].join(', '))
}) })
report.push('\n') report.push('\n')
// conflicts...
Object.keys(c).forEach(function(k){ Object.keys(c).forEach(function(k){
report.push(k + ': must setup after:\n ' + c[k].join(', ')) report.push(k + ': must setup after:\n ' + c[k].join(', '))
}) })
// break...
throw 'Feature dependency error:\n ' + report.join('\n ') throw 'Feature dependency error:\n ' + report.join('\n ')
} }