flynx/ImageGrid
1
1
Fork 0
mirror of https://github.com/flynx/ImageGrid.git synced 2025-10-29 18:30:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

started unraveling scroll-position issue...

Browse Source 
Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
Alex A. Naanou 2019-07-30 16:18:31 +03:00
parent 09daaf0e28
commit 2abc7ea087
1 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
ui (gen4)/lib/widget/browse2.js
View File

@ -4585,17 +4585,20 @@ var HTMLBrowserPrototype = {
// on render that can affect scroll position, e.g. partial
// render...
// XXX need to trigger the setup for this from .render(..) itself...
// XXX BUG: context.root === this is true for non-root containers too...
//
// to reproduce:
// dialog.collapse('B/C/D')
//
// this works fine:
// dialog.get('B/C/D').collapsed = true
// dialog.render()
//
// ...this appears to be due to .render(..) not being called
// from the root object in case #1, need more investigating...
if(context.root === this && context.scroll_offset){
var ref = this.focused || this.pagetop
// XXX for some reason this can be null...
// ...this seems to be the case for nested browsers, their
// .dom looks to be still ditached from main dom at this
// point... (setTimeout(.., 0) does not fix this)
// ...one likely cause can be that we are someplace
// creating the elem twice, i.e. once within the nested
// browser and the other outside -- check...
var scrolled = ref.dom.offsetParent
scrolled.scrollTop =
ref.elem.offsetTop - scrolled.scrollTop - context.scroll_offset
}