From 2e81b0407eeb6a0cf2d3bf25f757d26b4d7ae380 Mon Sep 17 00:00:00 2001 From: "Alex A. Naanou" Date: Wed, 19 Dec 2018 04:42:27 +0300 Subject: [PATCH] minor cleanup.. Signed-off-by: Alex A. Naanou --- ui (gen4)/imagegrid/tags.js | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/ui (gen4)/imagegrid/tags.js b/ui (gen4)/imagegrid/tags.js index 3abfd1a9..46c9e788 100755 --- a/ui (gen4)/imagegrid/tags.js +++ b/ui (gen4)/imagegrid/tags.js @@ -30,7 +30,8 @@ * XXX should this serialize recursively down??? * ...it might be a good idea to decide on a serialization * protocol and use it throughout... -* XXX should .tags() return all the used tags + .persistent or .persistentAll ??? +* XXX should .tags() return all the used tags + .persistent or +* .persistentAll ??? * * * @@ -53,6 +54,8 @@ var util = require('lib/util') // .someMethod(arg, ..) // .someMethod([arg, ..]) // +// +// XXX better docs -- signature... var normalizeSplit = function(args){ return (args.length == 1 && args[0] instanceof Array) ? args.pop() @@ -968,7 +971,6 @@ var BaseTagsPrototype = { // // XXX need to sanitize tag -- it can not contain regex characters... // ...should we guard against this??? - // XXX should both sides of the definition be renamed??? rename: function(tag, to, ...tags){ var that = this @@ -1172,10 +1174,6 @@ var BaseTagsPrototype = { // NOTE: this will also clear the index... this.define(tag, null) - // XXX add the def... - //this.definitions = (this.definitions || new Set()) - // .add(value +'/'+ tag) - // update the index... this.definitions = definitions || {} this.definitions[tag] = this.splitSet(value)