flynx/ImageGrid
1
1
Fork 0
mirror of https://github.com/flynx/ImageGrid.git synced 2025-10-30 02:40:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

minor tweaks + updated docs...

Browse Source 
Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
Alex A. Naanou 2014-10-06 16:32:15 +04:00
parent 8a9292f81f
commit 2fcb376f13
1 changed files with 24 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
ui (gen4)/lib/actions.js
View File

@ -131,12 +131,20 @@ function args2array(args){
// registered from the current object and up to the base action set // registered from the current object and up to the base action set
// will be fired. // will be fired.
// //
// NOTE: actions once defined do not depend on the inheritance hierarchy, // NOTE: actions once defined do not depend on the inheritance hierarchy,
// but they do on the other hand depend on methods defined in the // other than the .getHandlers(..) method. If this method is not
// MetaActions object. // found in the inheritance chain (i.e. the link to MetaActions)
// XXX should this be the case??? // was severed, then the default will be used:
// MetaActions.getHandlers(..)
// This makes it possible to redefine the method if needed but
// prevents the system from breaking when an action set gets
// disconnected from MetaActions. This can be useful, for example,
// to remove .on(..) / .off(..) handler functionality.
// XXX is this correct??
// NOTE: by default an action will return 'this', i.e. the action set // NOTE: by default an action will return 'this', i.e. the action set
// object the action was called from. // object the action was called from.
//
// XXX do we need to return something from an action ever?
var Action = var Action =
module.Action = module.Action =
function Action(name, doc, ldoc, func){ function Action(name, doc, ldoc, func){
@ -158,6 +166,9 @@ function Action(name, doc, ldoc, func){
var that = this var that = this
var args = args2array(arguments) var args = args2array(arguments)
var getHandlers = this.getHandlers
getHandlers = getHandlers == null ? MetaActions.getHandlers : getHandlers
// get and call handlers -- pre phase... // get and call handlers -- pre phase...
// //
// NOTE: using CLASS.__proto__[name].call(this, ...) here is not // NOTE: using CLASS.__proto__[name].call(this, ...) here is not
@ -166,7 +177,7 @@ function Action(name, doc, ldoc, func){
// ...searching the inheritance chain is not reliable as a // ...searching the inheritance chain is not reliable as a
// method can be referenced more than once, both with the // method can be referenced more than once, both with the
// same as well as under different names... // same as well as under different names...
var handlers = this.getHandlers(name) var handlers = getHandlers(name)
.map(function(h){ return h.apply(that, args) }) .map(function(h){ return h.apply(that, args) })
// NOTE: this action will get included and called by the code // NOTE: this action will get included and called by the code
@ -212,17 +223,11 @@ var MetaActions =
module.MetaActions = { module.MetaActions = {
// List actions... // List actions...
// //
// NOTE: this will only list all actions except the ones defined in get actions(){
// MetaActions, unless 'all' is set...
actions: function(all){
var res = [] var res = []
for(var k in this){ for(var k in this){
// get only actions... // get only actions...
if(this[k] instanceof Action if(this[k] instanceof Action){
// if all is true, get all actions...
&& !all
// if all is false, skip actions defined in MetaActions...
|| MetaActions.hasOwnProperty(k)){
res.push(k) res.push(k)
} }
} }
@ -230,11 +235,13 @@ module.MetaActions = {
}, },
// Number of defined actions... // Number of defined actions...
//
get length(){ get length(){
return this.actions.length return this.actions.length
}, },
// get action documentation... // Get action documentation...
//
getDoc: function(actions){ getDoc: function(actions){
var res = {} var res = {}
var that = this var that = this
@ -255,8 +262,9 @@ module.MetaActions = {
return res return res
}, },
// collect all the handlers from the inheritance chain and arrange // Collect all the handlers from the inheritance chain and arrange
// them up-down, first defined to last... // them up-down, first defined to last...
//
getHandlers: function(name){ getHandlers: function(name){
var handlers = [] var handlers = []
var cur = this var cur = this
@ -281,6 +289,7 @@ module.MetaActions = {
return handlers return handlers
}, },
// Register an action callback... // Register an action callback...
// //
// Register a post action callback // Register a post action callback