minor refactoring...

Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
Alex A. Naanou 2016-03-28 22:12:22 +03:00
parent 14b2cab73d
commit 35077407c1
2 changed files with 10 additions and 5 deletions

View File

@ -203,15 +203,17 @@ module.LifeCycle = ImageGridFeatures.Feature({
// object returned by the .saveWorkspace() action. // object returned by the .saveWorkspace() action.
// NOTE: it is recommended that a feature save its relevant .config // NOTE: it is recommended that a feature save its relevant .config
// data as-is. // data as-is.
// NOTE: no other action or state change should be triggered by this.
// - react to .loadWorkspace(..) by loading it's state from the returned // - react to .loadWorkspace(..) by loading it's state from the returned
// object... // object...
// NOTE: this can be active, i.e. a feature may call actions when
// handling this.
// - react to .toggleChrome(..) and switch on and off the chrome // - react to .toggleChrome(..) and switch on and off the chrome
// visibility... (XXX) // visibility... (XXX)
// //
// //
var WorkspaceActions = var WorkspaceActions = actions.Actions({
module.WorkspaceActions = actions.Actions({
config: { config: {
'workspace': 'default', 'workspace': 'default',
'chrome-visible': 'on', 'chrome-visible': 'on',
@ -260,9 +262,6 @@ module.WorkspaceActions = actions.Actions({
return this.config['saved-workspaces'][name] || {} return this.config['saved-workspaces'][name] || {}
}], }],
// toggle chrome on and off...
toggleChrome: ['Workspace|Interface/Toggle chrome',
makeConfigToggler('chrome-visible', ['off', 'on'])],
toggleWorkspace: ['Workspace/Toggle Workspace', toggleWorkspace: ['Workspace/Toggle Workspace',
makeConfigToggler('workspace', makeConfigToggler('workspace',
function(){ return Object.keys(this.config['saved-workspaces']) }, function(){ return Object.keys(this.config['saved-workspaces']) },

View File

@ -691,6 +691,12 @@ module.ViewerActions = actions.Actions({
this.reload() this.reload()
}], }],
// toggle chrome on and off...
// XXX should this be here???
toggleChrome: ['Workspace|Interface/Toggle chrome',
core.makeConfigToggler('chrome-visible', ['off', 'on'])],
}) })
var Viewer = var Viewer =