flynx/ImageGrid
1
1
Fork 0
mirror of https://github.com/flynx/ImageGrid.git synced 2025-10-29 02:10:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

removed the last of the control-flow setTimeout's from browse.js...

Browse Source 
Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
Alex A. Naanou 2017-01-20 20:37:11 +03:00
parent 89668fc080
commit 37f601f77b
2 changed files with 20 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ui (gen4)/features/filesystem.js
View File

@ -921,7 +921,9 @@ var FileSystemLoaderUIActions = actions.Actions({
var so = that.Overlay(
browse.makeList(null, loaders,
{
path: Object.keys(loaders)[0]
// select first...
//path: Object.keys(loaders)[0],
path: 0,
})
// close self and parent...
.open(function(){

34
ui (gen4)/lib/widget/browse.js
View File

@ -133,6 +133,7 @@ function(text, options){
// ...
// }
//
// NOTE: this need selection enabled in CSS...
Items.Selected =
function(text, options){
var elem = (options.action ? this.Action : this).call(this, text, options)
@ -2869,23 +2870,22 @@ var BrowserPrototype = {
}
// load the initial state...
//
// NOTE: this used to be run in the timeout below, it turned out
// to be a really bad idea mainly because the events bound
// in .list(..) turned out to be bound AFTER the events bound
// in the function that called the constructor, which messed
// up the triggering order...
that.update(options.path || that.path || '/')
// Select the default path...
//
// NOTE: this may not work when the dialog is loaded async...
setTimeout(function(){
// in case we have a manually selected item but that was
// not aligned...
that.selected && that.select()
}, 0)
// NOTE: path can be a number so simply or-ing here is a bad idea...
var path = options.path != null ? options.path : that.path
typeof(path) == typeof(123) ?
// select item number...
that
.update()
.then(function(){
that.select(path) })
// select path...
: that
.update(path || '/')
// Select the default path...
.then(function(){
// in case we have a manually selected item but that was
// not aligned...
that.selected && that.select() })
},
}