flynx/ImageGrid
1
1
Fork 0
mirror of https://github.com/flynx/ImageGrid.git synced 2025-10-30 19:00:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

now .makeSparseImages(..) if close to O(n) when the set is mostly sorted, so all connected operations are quite a bit faster, especially shifting left/right...

Browse Source 
Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
Alex A. Naanou 2015-12-07 04:25:35 +03:00
parent 61eea2938e
commit 440eedbb36
1 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
ui (gen4)/data.js
View File

@ -230,8 +230,16 @@ var DataPrototype = {
gids = gids.slice() gids = gids.slice()
} }
gids.forEach(function(e){ gids.forEach(function(e, i){
var i = order.indexOf(e) // if the element is in its place alredy do nothing...
if(e == order[i] && e == target[i]){
return
}
// NOTE: try and avoid the expensive .indexOf(..) as much as
// possible...
i = e != order[i] ? order.indexOf(e) : i
if(i >= 0){ if(i >= 0){
var o = target[i] var o = target[i]
// save overwritten target items if keep_target_items // save overwritten target items if keep_target_items
@ -1233,7 +1241,7 @@ var DataPrototype = {
}, },
// Gather gids into an connected section... // Gather gids into a connected section...
// //
// The section is positioned relative to a reference gid, which also // The section is positioned relative to a reference gid, which also
// determines the ribbon. // determines the ribbon.
@ -1357,7 +1365,8 @@ var DataPrototype = {
} }
}) })
// XXX this is cheating... // NOTE: this is cheating, but if it's fast and simple I do
// not care ;)
this.updateImagePositions() this.updateImagePositions()
} }
@ -1873,6 +1882,8 @@ var DataPrototype = {
// //
// Targets MUST be listed in order of occurrence. // Targets MUST be listed in order of occurrence.
// //
// Returns list of split sections.
//
// NOTE: this will not affect the original data object... // NOTE: this will not affect the original data object...
// NOTE: this might result in empty ribbons, if no images are in a // NOTE: this might result in empty ribbons, if no images are in a
// given ribbon in the section to be split... // given ribbon in the section to be split...
@ -1935,6 +1946,7 @@ var DataPrototype = {
// if it is needed to keep the original intact, just .clone() it... // if it is needed to keep the original intact, just .clone() it...
// //
// XXX test more complex cases... // XXX test more complex cases...
// XXX appears to be broken for joining sets via 'base' align...
join: function(){ join: function(){
var args = Array.apply(null, arguments) var args = Array.apply(null, arguments)
var align = typeof(args[0]) == typeof('str') ? args.splice(0, 1)[0] : 'base' var align = typeof(args[0]) == typeof('str') ? args.splice(0, 1)[0] : 'base'