From 4414bd0e7aae63f2a2aab5ae04de89f972838e32 Mon Sep 17 00:00:00 2001 From: "Alex A. Naanou" Date: Fri, 4 Dec 2020 05:22:57 +0300 Subject: [PATCH] notes... Signed-off-by: Alex A. Naanou --- Viewer/features/core.js | 2 +- Viewer/features/sharp.js | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/Viewer/features/core.js b/Viewer/features/core.js index 22596c6c..52c4e0f4 100755 --- a/Viewer/features/core.js +++ b/Viewer/features/core.js @@ -2670,6 +2670,7 @@ function(name, func){ // NOTE: sync-mode actions do not externally log anything, basic progress // logging is handled by the queue/task which is not created in sync // mode. +// NOTE: since the sync-mode can block it must be used very carefully. // // XXX check if item is already in queue... var queueHandler = @@ -2748,7 +2749,6 @@ function(name, func){ { __session_task__: true }) } - // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - // XXX revise logging and logger passing... diff --git a/Viewer/features/sharp.js b/Viewer/features/sharp.js index 8354e248..67cb5840 100755 --- a/Viewer/features/sharp.js +++ b/Viewer/features/sharp.js @@ -437,6 +437,7 @@ var SharpActions = actions.Actions({ Promise.reject('aborted') : res }) })], + // XXX move to core.queue... // XXX this does not update image.base_path -- is this correct??? // XXX add support for offloading the processing to a thread/worker... makePreviews: ['Sharp|File/Make image $previews',