flynx/ImageGrid
1
1
Fork 0
mirror of https://github.com/flynx/ImageGrid.git synced 2025-10-29 10:20:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

cleanup...

Browse Source 
Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
Alex A. Naanou 2016-11-28 02:37:57 +03:00
parent d5088fae68
commit 44368d9f78
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
ui (gen4)/features/history.js
View File

@ -462,7 +462,13 @@ var URLHistoryUIActions = actions.Actions({
// pinned items...
history
.filter(function(p){
return that.url_history[p].pinned
// NOTE: yes direct access is faster, but
// calling the toggler (common API) here
// will isolate the level knowledge to a
// single point which will simplify things
// if anything changes...
//return that.url_history[p].pinned
return that.toggleURLPinned(p, '?') == 'on'
})
.forEach(function(p){
// prevent from drawing again...
@ -515,7 +521,6 @@ var URLHistoryUIActions = actions.Actions({
// pin to top...
// XXX should this be standard functionality???
// XXX should this .setTopURLHistory(..)???
// XXX should we get pinned state via .toggleURLPinned(url, '?') here???
['<span class="pin-set">&#9679;</span>'
+'<span class="pin-unset">&#9675;</span>',
function(p){
@ -528,13 +533,11 @@ var URLHistoryUIActions = actions.Actions({
// pinned...
if(cur.hasClass('pinned')){
cur.removeClass('pinned')
//delete that.url_history[p].pinned
that.toggleURLPinned(p, 'off')
// not pinned...
} else {
cur.addClass('pinned')
//that.url_history[p].pinned = true
that.toggleURLPinned(p, 'on')
}