cleanup + updated todo...

Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
Alex A. Naanou 2013-12-23 03:57:18 +04:00
parent d211857b08
commit 49e8da7070
3 changed files with 19 additions and 29 deletions

View File

@ -117,7 +117,7 @@ Roadmap
| |
| Race condition?? | Race condition??
| |
| Can't reproduce this... | Can't reproduce this... need to test on a faster machine...
[X] BUG: appear to be leaking memory on very large sets of images (>8K) [X] BUG: appear to be leaking memory on very large sets of images (>8K)
| don't remember it before, so it might be due to the new | don't remember it before, so it might be due to the new
| loadImagesAround(..) | loadImagesAround(..)
@ -527,6 +527,15 @@ Roadmap
[_] side-by side view... [_] side-by side view...
[_] Simplify tool-tip structure in dialogs... [_] Simplify tool-tip structure in dialogs...
| might also bee good to unify tool-tips across the app... | might also bee good to unify tool-tips across the app...
[_] BUG (low priority): dragging a sub-panel, over and out again is odd..
| i.e. if the placeholder moves...
|
| Expected:
| create a new panel and drop into it or revert
|
| Actual:
| drops to last placeholder
|
[X] BUG: zooming vertical images in single image view results in size jumping... [X] BUG: zooming vertical images in single image view results in size jumping...
| Reason: | Reason:
| This is due to the proportion ratio changing in one step... | This is due to the proportion ratio changing in one step...

View File

@ -4,18 +4,6 @@
<style> <style>
.docked-panels {
background: gray;
width: 100%;
height: 100%;
}
.viewer {
background: white;
width: 100%;
height: 100%;
}
</style> </style>
<script src="../ext-lib/jquery.js"></script> <script src="../ext-lib/jquery.js"></script>
@ -46,13 +34,6 @@ $(function(){
.find('.content') .find('.content')
.html('<h3>Panel C</h3>') .html('<h3>Panel C</h3>')
/*
$('.docked-panels')
.sortable({
cancel: '.viewer',
connectWith: '.panel-content',
})
*/
$('body') $('body')
@ -67,11 +48,6 @@ $(function(){
<body> <body>
<div class="docked-panels panel-content">
<div class="viewer">
</div>
</div>
</body> </body>
</html> </html>
<!-- vim:set ts=4 sw=4 : --> <!-- vim:set ts=4 sw=4 : -->

View File

@ -45,6 +45,11 @@ function makePanel(title, open, editable_title, keep_empty){
// wrapper for sub-panels... // wrapper for sub-panels...
// XXX dragging out, into another panel and back out behaves oddly:
// should:
// either revert or create a new panel
// does:
// drops to last placeholder
var content = $('<span class="panel-content content">') var content = $('<span class="panel-content content">')
.sortable({ .sortable({
forcePlaceholderSize: true, forcePlaceholderSize: true,
@ -53,14 +58,14 @@ function makePanel(title, open, editable_title, keep_empty){
zIndex: 9999, zIndex: 9999,
start: function(e, ui){ start: function(e, ui){
console.log('start') //console.log('start')
ui.item.data('isoutside', false) ui.item.data('isoutside', false)
ui.placeholder.height(ui.helper.outerHeight()); ui.placeholder.height(ui.helper.outerHeight());
ui.placeholder.width(ui.helper.outerWidth()); ui.placeholder.width(ui.helper.outerWidth());
}, },
// create a new panel when dropping outside of curent panel... // create a new panel when dropping outside of curent panel...
beforeStop: function(e, ui){ beforeStop: function(e, ui){
console.log('stop') //console.log('stop')
var c = 0 var c = 0
// do this only when dropping outside the panel... // do this only when dropping outside the panel...
@ -92,11 +97,11 @@ function makePanel(title, open, editable_title, keep_empty){
ui.item.data('isoutside', false) ui.item.data('isoutside', false)
}, },
over: function(e, ui){ over: function(e, ui){
console.log('over') //console.log('over')
ui.item.data('isoutside', false) ui.item.data('isoutside', false)
}, },
out: function(e, ui){ out: function(e, ui){
console.log('out') //console.log('out')
ui.item.data('isoutside', true) ui.item.data('isoutside', true)
}, },
}) })