From 4a01b8b39d5a2604e211e3b35011e389ee8602ff Mon Sep 17 00:00:00 2001 From: "Alex A. Naanou" Date: Mon, 3 Feb 2014 06:28:55 +0400 Subject: [PATCH] minor tweaks... Signed-off-by: Alex A. Naanou --- ui/TODO.otl | 12 ++++++++++++ ui/files.js | 1 - ui/marks.js | 4 +--- ui/tags.js | 13 +++++++++++++ ui/ui.js | 2 ++ ui/urlhistory.js | 2 +- 6 files changed, 29 insertions(+), 5 deletions(-) diff --git a/ui/TODO.otl b/ui/TODO.otl index 25894e70..0356c2cd 100755 --- a/ui/TODO.otl +++ b/ui/TODO.otl @@ -110,6 +110,18 @@ Roadmap [_] 32% Gen 3 current todo [_] 65% High priority + [_] BUG: info dialog breaks when using a self-generated data... + | Procedure: + | - open: file:///L:/mnt/hdd13 (photo)/NTFS2/media/img/my/work/- 20140203Y.001 - Gordosevich opening, Kiril,/DCIM/preview (RAW)/Gordosevich-opening-select/ + | - press 'I' + | + | Expected: + | info dialog... + | + | Getting: + | error @ 84* line: .length of undefined... + | + | XXX make info fool proof... [_] make buildcache sort images via data AND file name... [_] BUG: panels: open/close events get triggered on panel drag/sort... [_] buildcache: add option to control image sort... diff --git a/ui/files.js b/ui/files.js index 17f9827e..4933dd15 100755 --- a/ui/files.js +++ b/ui/files.js @@ -7,7 +7,6 @@ //var DEBUG = DEBUG != null ? DEBUG : true // Flag indicating a new image file was constructed... -// XXX do we need this? var IMAGES_CREATED = false var IMAGE_PATTERN = /.*\.(jpg|jpeg|png|gif)$/i diff --git a/ui/marks.js b/ui/marks.js index 05c3db4f..d7fa0563 100755 --- a/ui/marks.js +++ b/ui/marks.js @@ -381,9 +381,7 @@ function cropMarkedImages(keep_ribbons, keep_unloaded_gids){ * Modes */ -// XXX is this a mode??? -var toggleMarkedOnlyView = makeCropModeToggler( - cropMarkedImages) +var toggleMarkedOnlyView = makeCropModeToggler(cropMarkedImages) var toggleMarkedOnlyWithRibbonsView = makeCropModeToggler( diff --git a/ui/tags.js b/ui/tags.js index 0159c30b..b4c40d33 100755 --- a/ui/tags.js +++ b/ui/tags.js @@ -500,6 +500,19 @@ function tagsUpdated(){ +/********************************************************************** +* Dialogs/panels... +*/ + +// XXX add tags to: +// - loaded images +// - marked images +function batchTagImagesDialog(){ + // XXX +} + + + /********************************************************************** * Setup... */ diff --git a/ui/ui.js b/ui/ui.js index 0561ac15..21b41739 100755 --- a/ui/ui.js +++ b/ui/ui.js @@ -836,6 +836,8 @@ function showImageInfo(){ ''+ // basic info... + // XXX BUG: something here breaks when self-generated data is + // currently open -- .length of undefined... ''+ ''+ ''+ diff --git a/ui/urlhistory.js b/ui/urlhistory.js index dad2290c..511d93ef 100755 --- a/ui/urlhistory.js +++ b/ui/urlhistory.js @@ -11,7 +11,7 @@ var BASE_URL_HISTORY = [] var BASE_URL_HISTORY_LIMIT = 50 -var BASE_URL_HISTORY_DIALOG_LIMIT = 15 +var BASE_URL_HISTORY_DIALOG_LIMIT = 20
GID: '+ gid +'
Date: '+ date +'