flynx/ImageGrid
1
1
Fork 0
mirror of https://github.com/flynx/ImageGrid.git synced 2025-10-29 10:20:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

prep for refactoring of .match(..)

Browse Source 
Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
Alex A. Naanou 2018-12-21 18:59:59 +03:00
parent 7c123bdcca
commit 4a91709ffb
1 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
ui (gen4)/imagegrid/tags.js
View File

@ -558,12 +558,25 @@ var BaseTagsPrototype = {
// // path search is directional... // // path search is directional...
// ts.match('c', 'a') // -> false // ts.match('c', 'a') // -> false
// //
// XXX Q: should the following be true?
// ts.togglePersistent('a/b/c', 'z/a/x/y', 'on')
//
// ts.match('/a', 'y') // -> ??? (currently false)
//
// ...feels like this should be true...
match: function(a, b, cmp){ match: function(a, b, cmp){
var that = this var that = this
// root or base? // root or base?
var edge = /^\s*[\\\/]/.test(a) var edge = /^\s*[\\\/]/.test(a)
|| /[\\\/]\s*$/.test(a) || /[\\\/]\s*$/.test(a)
// NOTE: if we have a at least once present in an edge path then
// it means the edge is reachable and thus no need to test
// for it explicitly...
// XXX this is valid iff a is a single tag, if it's a sub-path
// then we need to check only the first item... (???)
// XXX is this applicable to both root and base???
edge = !(edge && this.directMatch(a).length > 0)
// get paths with tag... // get paths with tag...
var paths = function(tag){ var paths = function(tag){
@ -577,6 +590,8 @@ var BaseTagsPrototype = {
return paths(tag) return paths(tag)
.reduce(function(res, path){ .reduce(function(res, path){
if(res == true if(res == true
// XXX do we need this??? (I think not)
// ...see the edge test above...
|| (edge && !that.directMatch(a, path))){ || (edge && !that.directMatch(a, path))){
return res return res
} }