flynx/ImageGrid
1
1
Fork 0
mirror of https://github.com/flynx/ImageGrid.git synced 2025-10-29 18:30:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

cleanup + some doc...

Browse Source 
Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
Alex A. Naanou 2016-06-30 05:50:20 +03:00
parent 19c2b2028e
commit 4d095ea351
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ui (gen4)/lib/features.js
View File

@ -327,6 +327,8 @@ var FeatureSetProto = {
// XXX should meta-features be MetaFeature objects??? // XXX should meta-features be MetaFeature objects???
// XXX not sure about handling excluded features (see inside)... // XXX not sure about handling excluded features (see inside)...
// XXX add dependency loops to .conflicts... // XXX add dependency loops to .conflicts...
// XXX might be a good idea to check dependency loops on feature
// construction, too... (???)
buildFeatureList: function(obj, lst){ buildFeatureList: function(obj, lst){
var that = this var that = this
obj = obj || {} obj = obj || {}
@ -374,6 +376,9 @@ var FeatureSetProto = {
// ...unless there is an infinite number of features, but // ...unless there is an infinite number of features, but
// I'll try to avoid that big a feature creep. // I'll try to avoid that big a feature creep.
// XXX should we check for dependency loops here??? // XXX should we check for dependency loops here???
// ...this would have been simple if this was a recursion
// (just check if cur is in path), but here it is not
// trivial...
for(var i=0; i < lst.length; i++){ for(var i=0; i < lst.length; i++){
var k = lst[i] var k = lst[i]