flynx/ImageGrid
1
1
Fork 0
mirror of https://github.com/flynx/ImageGrid.git synced 2025-10-31 03:10:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

cleanup...

Browse Source 
Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
Alex A. Naanou 2015-12-29 01:40:10 +03:00
parent c9400b83a0
commit 4f12f725fb
2 changed files with 5 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ui (gen4)/features/filesystem.js
View File

@ -22,6 +22,9 @@ if(window.nodejs != null){
var browseWalk = require('lib/widget/browse-walk') var browseWalk = require('lib/widget/browse-walk')
} }
var data = require('data')
var images = require('images')
var util = require('lib/util') var util = require('lib/util')
var actions = require('lib/actions') var actions = require('lib/actions')
@ -227,6 +230,7 @@ var FileSystemLoaderActions = actions.Actions({
}], }],
// XXX merging does not work (something wrong with .data.join(..)) // XXX merging does not work (something wrong with .data.join(..))
// ...fixed a bug in images.js hash generator, now might be fixed...
// XXX revise logger... // XXX revise logger...
loadNewImages: ['File/Load new images', loadNewImages: ['File/Load new images',
function(path, logger){ function(path, logger){

33
ui (gen4)/ribbons.js
View File

@ -61,21 +61,11 @@ var RIBBON = '.ribbon:not(.clone)'
// NOTE: there can be only one .ribbon-set element. // NOTE: there can be only one .ribbon-set element.
// //
// //
// XXX need to replace soemlegacy CSS API and make this compatible with
// modern libs like velocity.js...
// - jli.getRelativeOffset(..)
// - jli.getElementOrigin(..)
// - jli.getElementScale(..)
// - jli.setElementScale(..)
// - jli.setElementOffset(..)
// - jli.shiftOriginTo(..)
// XXX think if a way to manage animation timings...
//
//
// //
/*********************************************************************/ /*********************************************************************/
// Low Level dom access... // Low Level dom access...
// //
// XXX think if a way to manage animation timings...
// XXX not sure if this is the right way to go... // XXX not sure if this is the right way to go...
var legacyDOMAdapter = var legacyDOMAdapter =
@ -96,27 +86,6 @@ module.legacyDOMAdapter = {
} }
// XXX BUG: ...
// to reproduce:
// - .focusImage('j')
// - .toggleSingleImage('on')
// the image disappears... (wrong offset)
//
// also reproducable in ribbon mode...
//
//
// appears to be connected to partial ribbon loading in single
// image mode -- current image gets reloaded for some reason...
//
// seems to be a problem with resizeRibbon compensating and syncicng
// differently as above...
// ...the problem is that when the ribbon gets resized, the initial offset is wrong...
//
// the problem is present in both cases, but the timing is different
// so it is easier to spot here...
// ...appears to be connected with translate+origin vs. left being
// used to aign ribbons...
var DOMAdapter = var DOMAdapter =
module.DOMAdapter = { module.DOMAdapter = {
getOrigin: function(elem){ getOrigin: function(elem){