flynx/ImageGrid
1
1
Fork 0
mirror of https://github.com/flynx/ImageGrid.git synced 2025-10-29 18:30:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

cleanup and notes...

Browse Source 
Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
Alex A. Naanou 2019-10-13 05:35:29 +03:00
parent 122baa837d
commit 52a972715f
1 changed files with 15 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
ui (gen4)/features/virtual-blocks.js
View File

@ -28,6 +28,10 @@ var browse = require('lib/widget/browse')
// // Block text (optional)... // // Block text (optional)...
// text: <String>, // text: <String>,
// //
// // export constructor action...
// // XXX not implemented yet...
// //export: <action>,
//
// // optional image attributes... // // optional image attributes...
// // for more info see: imagegrid/images.js // // for more info see: imagegrid/images.js
// ... // ...
@ -36,14 +40,20 @@ var browse = require('lib/widget/browse')
// XXX should these be sortable and how??? // XXX should these be sortable and how???
// ...relative placement (i.e. "before <GID>")??? // ...relative placement (i.e. "before <GID>")???
// XXX should the export mechanism be extensible??? // XXX should the export mechanism be extensible???
// ...i.e. some way to identify the block and get it's ext and file content... // ...i.e. some way to identify the block and get its .ext and file content...
// one way to do this is to add an attr:
// export: <action(gid, data)>
// ...this could also be a generic API, not specific to 'virtual-blocks'
// implementing such export actions as:
// exportPreview(..)
// exportText(..)
// ...
//
// //
var VirtualBlocksActions = actions.Actions({ var VirtualBlocksActions = actions.Actions({
// construction of new "virtual images"... // construction of new "virtual images"...
// //
// XXX do better arg processing -- handle metadata correctly... // XXX do better arg processing -- handle metadata correctly...
// XXX add export support for this type of stuff...
// text -> file.txt
makeVirtualBlock: ['- $Virtual block/', makeVirtualBlock: ['- $Virtual block/',
function(ref, offset, metadata){ function(ref, offset, metadata){
ref = ref || 'current' ref = ref || 'current'
@ -89,8 +99,8 @@ var VirtualBlocksActions = actions.Actions({
this.focusImage(gid) this.focusImage(gid)
}], }],
// XXX this is enabled only in crop mode as there is no way to delete // XXX this is enabled only in collection view as there is no way
// a block but possible to create one... // to delete a block but possible to create one...
// ...should we add a .removeBlock(..) action??? // ...should we add a .removeBlock(..) action???
makeVirtualBlank: ['Virtual block/50:Add blank $after', makeVirtualBlank: ['Virtual block/50:Add blank $after',
core.doc` core.doc`