From 531d4e610c0dbf556088d6f86602da97530f2623 Mon Sep 17 00:00:00 2001 From: "Alex A. Naanou" Date: Thu, 18 Jun 2015 18:18:28 +0300 Subject: [PATCH] minor cleanup, tweaking and docs... Signed-off-by: Alex A. Naanou --- ui (gen4)/experiments/browse-dialog.js | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/ui (gen4)/experiments/browse-dialog.js b/ui (gen4)/experiments/browse-dialog.js index 2906c79e..58e3a4e1 100755 --- a/ui (gen4)/experiments/browse-dialog.js +++ b/ui (gen4)/experiments/browse-dialog.js @@ -201,8 +201,6 @@ var BrowserPrototype = { return this }, - // internal actions... - // Filter the item list... // // .filter() @@ -212,25 +210,33 @@ var BrowserPrototype = { // .filter() // -> elements // - // .filter() + // .filter() // -> elements // // .filter() // -> elements // // + // .filter([, ][, ]) + // + // XXX write out the following signatures... + // .filter() + // .filter(, ) + // .filter(, ) + // .filter(, , ) + // // XXX pattern modes: // - lazy match // abc -> *abc* -> ^.*abc.*$ // ab cd -> *ab*cd* -> ^.*ab.*cd.*$ // - glob - // - regex // XXX need to support glob / nested patterns... // ..things like /**/a*/*moo/ - // XXX make the signature a bit more flexible... filter: function(pattern, rejected, ignore_disabled){ pattern = pattern || '*' + ignore_disabled = typeof(rejected) == typeof(true) ? rejected : ignore_disabled ignore_disabled = ignore_disabled == null ? true : ignore_disabled + rejected = typeof(rejected) == typeof(true) ? null : rejected var that = this var browser = this.dom @@ -285,6 +291,9 @@ var BrowserPrototype = { return elems.filter(filter) }, + + // internal actions... + // NOTE: this uses .filter(..) for actual filtering... // XXX revise API... showFiltered: function(pattern){