flynx/ImageGrid
1
1
Fork 0
mirror of https://github.com/flynx/ImageGrid.git synced 2025-10-28 18:00:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

notes...

Browse Source 
Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
Alex A. Naanou 2019-12-09 04:45:38 +03:00
parent 0ffcda0e4e
commit 5d1c53593c
1 changed files with 2 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
ui (gen4)/features/ui-widgets.js
View File

@ -1019,21 +1019,8 @@ browse.items.makeSubContext = function(name, obj){
// XXX EXPERIMENT...
// Q: What should we use as context for the getters and callbacks?
// ...there are several ways to go:
// - "this" generic make object + manual binding
// + generic, already implemented...
// - requires manual binding...
// - explicit context in arguments or options
// - breaks the general API...
// - a context manager API... (REJECTED?)
// - complexity...
// Q: should we add domain specific fields here too???
// ...would be nice to be able to add domains to make(..), e.g.:
// make.Domain('ig')
// make.ig.attrToggle = function(..){ ... }
// the goal is to preserve the make(..) context in sub calls, see
// browse.items.Domain(..) implemented below...
// XXX Q: should we add an ImageGrid context to make(..)???
// ...something like .app for making it generic-ish for example...
// XXX Q: do we actually need .Field(..), it does everything make(..)
// does already???
// XXX Q: should title/value args be optional???