cleanup...

Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
Alex A. Naanou 2016-04-13 05:45:10 +03:00
parent 86b311361e
commit 6b75a98d44
3 changed files with 9 additions and 11 deletions

View File

@ -17,8 +17,9 @@
position: relative; position: relative;
color: #ffffff; color: #ffffff;
font-size: 10px; font-size: 8px;
margin: 20px auto; //margin: 15px auto;
margin-bottom: 15px;
text-indent: -9999em; text-indent: -9999em;

View File

@ -251,8 +251,6 @@ module.MetadataReader = core.ImageGridFeatures.Feature({
// XXX add identical fields -- show first available and hide the rest... // XXX add identical fields -- show first available and hide the rest...
// 'Shutter Speed', 'Exposure Time', // 'Shutter Speed', 'Exposure Time',
// 'Lens ID', 'Lens' // 'Lens ID', 'Lens'
// XXX show all fields but make some of them hidden/disabled
// -- togglable via D
// XXX add field editing... (open) // XXX add field editing... (open)
// XXX might be good to split this to sections... // XXX might be good to split this to sections...
// - base info // - base info
@ -261,7 +259,6 @@ module.MetadataReader = core.ImageGridFeatures.Feature({
// - EXIF // - EXIF
// - IPTC // - IPTC
// - ... // - ...
// XXX should this be a panel or a list (as is now...)????
var MetadataUIActions = actions.Actions({ var MetadataUIActions = actions.Actions({
config: { config: {
'metadata-auto-select-modes': [ 'metadata-auto-select-modes': [
@ -307,7 +304,6 @@ var MetadataUIActions = actions.Actions({
// //
// XXX should we replace 'mode' with nested set of metadata??? // XXX should we replace 'mode' with nested set of metadata???
// XXX make this support multiple images... // XXX make this support multiple images...
// XXX make this updatable...
showMetadata: ['Image/Show metadata', showMetadata: ['Image/Show metadata',
function(image, mode){ function(image, mode){
var that = this var that = this
@ -529,22 +525,23 @@ module.MetadataFSUI = core.ImageGridFeatures.Feature({
], ],
handlers: [ handlers: [
// read and when done update the list... // Read metadata and when done update the list...
// XXX should this just wait for // XXX should we show what we can and wait for metadata load (current
// state) or wait and show everything in one go???
['showMetadata.pre', ['showMetadata.pre',
function(image){ function(image){
var that = this var that = this
var reader = this.readMetadata(image) var reader = this.readMetadata(image)
return reader && function(overlay){ return reader && function(overlay){
var client = overlay.client var client = overlay.client
var data = client.options.data var data = client.options.data
// add a loading indicator...
// NOTE: this will get removed when calling .updateMetadata()
data.push('---') data.push('---')
//data.push($('<center>Loading...</center>')) //data.push($('<center>Loading...</center>'))
data.push($('<center><div class="loader"/></center>')) data.push($('<center><div class="loader"/></center>'))
client.update() client.update()
reader.then(function(data){ reader.then(function(data){

View File

@ -905,7 +905,7 @@ var BrowserPrototype = {
// XXX is this the correct way to do this??? // XXX is this the correct way to do this???
var txt = p.text() var txt = p.text()
// XXX disable search??? // XXX disable search???
console.warn('jQuery objects as browse list elements not yet supported.') console.warn('jQuery objects as browse list elements not yet fully supported.')
// str and other stuff... // str and other stuff...
} else { } else {