From 71be1ccd68bbc5f25d863109cda54496d7e1b067 Mon Sep 17 00:00:00 2001 From: "Alex A. Naanou" Date: Sun, 3 Dec 2017 00:30:42 +0300 Subject: [PATCH] notes... Signed-off-by: Alex A. Naanou --- ui (gen4)/features/collections.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/ui (gen4)/features/collections.js b/ui (gen4)/features/collections.js index 060f36d2..ff0749de 100755 --- a/ui (gen4)/features/collections.js +++ b/ui (gen4)/features/collections.js @@ -70,6 +70,8 @@ module.COLLECTION_TRANSFER_CHANGES = [ //--------------------------------------------------------------------- +// XXX BUG: saving a list of collections when one collection is not +// loaded breaks... // XXX undo... var CollectionActions = actions.Actions({ config: { @@ -1689,6 +1691,8 @@ module.CollectionTags = core.ImageGridFeatures.Feature({ // clear and compact tags for all collections... rc && Object.keys(rc || {}) + // XXX skip unloaded collections... + .filter(function(title){ return !!rc[title].data }) .forEach(function(title){ var tags = c[title].local_tags || {} var rtags = {} @@ -1913,6 +1917,8 @@ module.AutoCollections = core.ImageGridFeatures.Feature({ //--------------------------------------------------------------------- // XXX show collections in image metadata... (???) +// XXX might be nice to indicate if a collection is loaded -- has .data... +// XXX rename collection ui... var UICollectionActions = actions.Actions({ config: { // Global default collections... @@ -2245,8 +2251,6 @@ module.UICollection = core.ImageGridFeatures.Feature({ // XXX collection id... // XXX Things to try/do: // - save collection on exit/write (?) -// - lazy load collections (load list, lazy-load data) -// - collection index // - load directories as collections (auto?)... // - export collections to directories... // - auto-export collections (on save)...