flynx/ImageGrid
1
1
Fork 0
mirror of https://github.com/flynx/ImageGrid.git synced 2025-11-03 21:00:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

cleanup...

Browse Source 
Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
Alex A. Naanou 2015-06-21 20:37:32 +03:00
parent f5d7fa4d95
commit 74f7eb6b1a
1 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
ui (gen4)/experiments/browse-dialog.js
View File

@ -95,7 +95,7 @@ var BrowserPrototype = {
flat: false, flat: false,
}, },
// XXX this should prevent event handler delegation... // XXX TEST: this should prevent event handler delegation...
keyboard: { keyboard: {
// filter mappings... // filter mappings...
Filter: { Filter: {
@ -187,13 +187,13 @@ var BrowserPrototype = {
// - build the element list // - build the element list
// - bind to control events // - bind to control events
// //
// XXX trigger an "update" event...
// XXX do we normalize path here??? // XXX do we normalize path here???
// XXX need a way to handle path errors in the extension API... // XXX need a way to handle path errors in the extension API...
// ...for example, if .list(..) can't list or lists a different // ...for example, if .list(..) can't list or lists a different
// path due to an error, we need to be able to render the new // path due to an error, we need to be able to render the new
// path both in the path and list sections... // path both in the path and list sections...
// NOTE: current behaviour is not wrong, it just not too flexible... // NOTE: current behaviour is not wrong, it just not too flexible...
// XXX trigger an "update" event...
update: function(path){ update: function(path){
path = path || this.path path = path || this.path
var browser = this.dom var browser = this.dom
@ -468,7 +468,7 @@ var BrowserPrototype = {
return this return this
}, },
// XXX make this a toggler... (???) // XXX should this be a toggler???
startFilter: function(){ startFilter: function(){
if(this.options.filter){ if(this.options.filter){
var range = document.createRange() var range = document.createRange()
@ -507,7 +507,6 @@ var BrowserPrototype = {
}, },
// XXX should this be a toggler??? // XXX should this be a toggler???
// XXX might be good for these to accept the same types as .select(..)
disableElements: function(pattern){ disableElements: function(pattern){
this.filter(pattern, false) this.filter(pattern, false)
.addClass('disabled') .addClass('disabled')
@ -579,10 +578,6 @@ var BrowserPrototype = {
// //
// //
// XXX Q: should this trigger a "select" event??? // XXX Q: should this trigger a "select" event???
// XXX the scroll handling might be a bit inaccurate...
// XXX Q: should this have a version that will just return the
// selected element without affecting the ui?
// ...something like .filter(..) vs. .showFiltered(..)
select: function(elem, filtering){ select: function(elem, filtering){
var pattern = '.list div:not(.disabled):not(.filtered-out)' var pattern = '.list div:not(.disabled):not(.filtered-out)'
var browser = this.dom var browser = this.dom
@ -816,7 +811,7 @@ var BrowserPrototype = {
return m ? m.apply(this, arguments) : [] return m ? m.apply(this, arguments) : []
}, },
// XXX need to get a container.... // XXX need to get a container -- UI widget API....
// XXX setup instance events... // XXX setup instance events...
__init__: function(parent, options){ __init__: function(parent, options){
options = options || {} options = options || {}