flynx/ImageGrid
1
1
Fork 0
mirror of https://github.com/flynx/ImageGrid.git synced 2025-10-29 18:30:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

notes...

Browse Source 
Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
Alex A. Naanou 2019-05-19 14:11:58 +03:00
parent 863e72f533
commit 786fc542ea
1 changed files with 18 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
ui (gen4)/lib/widget/browse2.js
View File

@ -253,6 +253,20 @@ var callItemEventHandlers = function(item, event, evt, ...args){
// //
// NOTE: item is compatible to .search(item, ..) spec, see that for more // NOTE: item is compatible to .search(item, ..) spec, see that for more
// details... // details...
//
// XXX need to trigger item parent's event too...
// Q: trigger once, per call or once per item???
// Q: should this be done here or in the client???
//
// XXX problems with event propagation:
// - the item can be within a nested browser/list and that
// container's events will not be triggered from here,
// just the item's, this and parent's...
// - if we get item.parent and trigger it's event directly
// then that event may propogate up and this' and this.parent's
// events may get triggered more than once...
// - we can not rely on full bottom/up propagation as some
// containers in the path may be basic Arrays...
var makeItemEventMethod = function(event, handler, options){ var makeItemEventMethod = function(event, handler, options){
options = Object.assign( options = Object.assign(
// NOTE: we need to be able to pass item objects, so we can not // NOTE: we need to be able to pass item objects, so we can not
@ -267,6 +281,7 @@ var makeItemEventMethod = function(event, handler, options){
function(evt, item, ...args){ function(evt, item, ...args){
handler handler
&& handler.call(this, evt, item.slice(), ...args) && handler.call(this, evt, item.slice(), ...args)
var parents = new Set()
item.forEach(function(item){ item.forEach(function(item){
callItemEventHandlers(item, event, evt, ...args) }) }) callItemEventHandlers(item, event, evt, ...args) }) })
return Object.assign( return Object.assign(
@ -1947,15 +1962,13 @@ var BaseBrowserPrototype = {
// XXX need a way to extend these to: // XXX need a way to extend these to:
// - be able to trigger an external (DOM) event... // - be able to trigger an external (DOM) event...
// - be able to be triggered from an external (DOM) event... // - be able to be triggered from an external (DOM) event...
// XXX should this return the focused item???? // XXX should we trigger direct item's parent event???
focus: makeItemEventMethod('focus', function(evt, items){ focus: makeItemEventMethod('focus', function(evt, items){
// NOTE: if we got multiple matches we care only about the first one...
var item = items.shift()
// blur .focused... // blur .focused...
this.focused this.focused
&& this.blur(this.focused) && this.blur(this.focused)
// NOTE: if we got multiple matches we care only about the first one...
var item = items.shift()
item != null item != null
&& (item.focused = true) && (item.focused = true)
}), }),