From 8ac7b160e696e494e5758da7b75770f95de8adea Mon Sep 17 00:00:00 2001
From: "Alex A. Naanou" <alex.nanou@gmail.com>
Date: Sat, 16 Jun 2012 21:52:23 +0400
Subject: [PATCH] cleanup and refactoring...

Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
---
 ui/gallery-prototype.js | 61 +++++++++++++++++++++++++----------------
 ui/gallery.html         |  4 +--
 2 files changed, 39 insertions(+), 26 deletions(-)

diff --git a/ui/gallery-prototype.js b/ui/gallery-prototype.js
index 77ec7327..71adc789 100755
--- a/ui/gallery-prototype.js
+++ b/ui/gallery-prototype.js
@@ -17,8 +17,8 @@ $(document).ready(function() {
 		.swipe({
 			swipeLeft: nextImage,
 			swipeRight: prevImage,
-			swipeUp: demoteImage,
-			swipeDown: promoteImage,
+			swipeUp: shiftImageUp,
+			swipeDown: shiftImageDown,
 		})
 		/* XXX jquery.mobile handlers... (with this I'm getting way too much bling)
 		.bind('swipeleft', function(e){
@@ -32,13 +32,13 @@ $(document).ready(function() {
 			return false
 		})
 		*/
-	$(".image").click(handleClick)
+	$(".image").click(handleImageClick)
 
 	// control elements...
 	$('.next-image').click(nextImage)
 	$('.prev-image').click(prevImage)
-	$('.demote').click(demoteImage)
-	$('.promote').click(promoteImage)
+	$('.demote').click(shiftImageUp)
+	$('.promote').click(shiftImageDown)
 	$('.toggle-wide').click(toggleWideView)
 	$('.toggle-single').click(toggleRibbonView)
 
@@ -50,9 +50,10 @@ $(document).ready(function() {
 
 	// set the default position and init...
 	$('.current-image').click()
-
 });
 
+
+
 function loadImages(json){
 	var images = json.images
 	var ribbon = $('.ribbon').last()
@@ -62,20 +63,22 @@ function loadImages(json){
 	for(var i = 0; i < images.length; i++){
 		$('<div class="image"></div>')
 			.css({ 'background-image': 'url('+images[i]+')' })
-			.click(handleClick)
+			.click(handleImageClick)
 			.appendTo(ribbon)
 	}
 	ribbon.children().first().click()
 }
 
+
+
 // XXX jquery.gestures handler...
 function handleGestures(e){
 	switch (e){
 		case 'N':
-			demoteImage()
+			shiftImageUp()
 			break
 		case 'S':
-			promoteImage()
+			shiftImageDown()
 			break
 		case 'E':
 			prevImage()
@@ -87,7 +90,8 @@ function handleGestures(e){
 }
 
 
-function handleClick(e) {
+
+function handleImageClick(e) {
 
 	var cur = $(this)
 
@@ -119,6 +123,10 @@ function handleClick(e) {
 	e.preventDefault();
 }
 
+
+
+// key configuration...
+// XXX need to make this handle modifiers gracefully...
 var keys = {
 	toggleHelpKeys: [72],
 	toggleRibbonView: [70],
@@ -151,20 +159,20 @@ function handleKeys(event){
 			if(event.ctrlKey){
 				createRibbon('next')
 			}
-			promoteImage()
+			shiftImageDown()
 		}()
 		: (fn(code, keys.demoteKeys) >= 0) ? function(){
 			if(event.ctrlKey){
 				createRibbon('prev')
 			}
-			demoteImage()
+			shiftImageUp()
 		}()
 		: (fn(code, keys.downKeys) >= 0) ? function(){
 			if(event.shiftKey){
 				if(event.ctrlKey){
 					createRibbon('next')
 				}
-				promoteImage()
+				shiftImageDown()
 			} else {
 				focusBelowRibbon()
 			}
@@ -174,7 +182,7 @@ function handleKeys(event){
 				if(event.ctrlKey){
 					createRibbon('prev')
 				}
-				demoteImage()
+				shiftImageUp()
 			} else {
 				focusAboveRibbon()
 			}
@@ -188,6 +196,7 @@ function handleKeys(event){
 }
 
 
+
 // modes...
 function showRibbon(){
 	$('.single-image-mode')
@@ -213,6 +222,9 @@ function toggleRibbonView(){
 	}
 }
 
+
+
+// XXX replace this with adequate zooming...
 // XXX need to reposition the whole thing correctly...
 function toggleWideView(){
 	if($('.wide-view-mode').length > 0){
@@ -236,34 +248,33 @@ function toggleWideView(){
 	}
 }
 
+
+
 // basic navigation...
 function firstImage(){
 	$('.current-ribbon').children('.image').first().click()
 }
-
 function prevImage(){
 	$('.current-image').prev('.image').click()
 }
-
 function nextImage(){
 	$('.current-image').next('.image').click()
 }
-
 function lastImage(){
 	$('.current-ribbon').children('.image').last().click()
 }
-
 // XXX select appropriate image...
 function focusAboveRibbon(){
 	$('.current-ribbon').prev('.ribbon').children('.image').first().click()
 }
-
 // XXX select appropriate image...
 function focusBelowRibbon(){
 	$('.current-ribbon').next('.ribbon').children('.image').first().click()
 }
 
 
+// basic actions...
+
 // create ribbon above/below helpers...
 function createRibbon(direction){
 	if(direction == 'next'){
@@ -291,7 +302,6 @@ function createRibbon(direction){
 }
 
 
-// Modifiers...
 
 // XXX sort elements correctly...
 function mergeRibbons(direction){
@@ -299,6 +309,7 @@ function mergeRibbons(direction){
 			.children()
 				.detach()
 				.insertAfter('.current-image')
+	// animate...
 	$('.current-ribbon')[direction]('.ribbon')
 			.slideUp(function(){
 				$(this).remove()
@@ -306,8 +317,11 @@ function mergeRibbons(direction){
 			})
 }
 
-// now the actual modifiers...
 
+
+// Modifiers...
+
+// now the actual modifiers...
 function shiftImage(direction){
 	if($('.current-ribbon')[direction]('.ribbon').length == 0){
 		createRibbon(direction)
@@ -331,13 +345,12 @@ function shiftImage(direction){
 	$('.current-image').click()
 }
 
-function promoteImage(){
+function shiftImageDown(){
 	return shiftImage('next')
 }
-
 // XXX this has problems, when creating a new ribbon this does not settle 
 //	   into a correct spot...
-function demoteImage(){
+function shiftImageUp(){
 	return shiftImage('prev')
 }
 
diff --git a/ui/gallery.html b/ui/gallery.html
index f37a07a2..463014b8 100755
--- a/ui/gallery.html
+++ b/ui/gallery.html
@@ -77,8 +77,8 @@
 
 	<br><br>
 
-	<button onclick="demoteImage()">demote image (shift-up)</button><br>
-	<button onclick="promoteImage()">promote image (shift-down)</button><br>
+	<button onclick="shiftImageUp()">demote image (shift-up)</button><br>
+	<button onclick="shiftImageDown()">promote image (shift-down)</button><br>
 	NOTE: ctrl-shift-up / ctrl-shift-down will demote / promote an image to a new empty ribbon (the default if no ribbon exists)
 
 	<br><br>