flynx/ImageGrid
1
1
Fork 0
mirror of https://github.com/flynx/ImageGrid.git synced 2025-10-29 18:30:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

notes...

Browse Source 
Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
Alex A. Naanou 2019-05-27 05:09:01 +03:00
parent e8670825cd
commit 8d6378d316
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
ui (gen4)/lib/widget/browse2.js
View File

@ -394,8 +394,8 @@ var makeItemEventMethod = function(event, handler, default_item, filter, options
// Generate item event/state toggler... // Generate item event/state toggler...
// //
// XXX should this be a toggler.Toggler??? // XXX should this make a toggler.Toggler???
// XXX the generated toggler in multi mode handles query arrays inconsistently... // XXX BUG: the generated toggler in multi mode handles query arrays inconsistently...
// - [] is always returned... // - [] is always returned...
// - .toggleSelect([1, 2, 10, 20]) -- toggles items on only, returns [] // - .toggleSelect([1, 2, 10, 20]) -- toggles items on only, returns []
// - .toggleSelect([1, 2, 10, 20], 'next') -- toggles items on only, returns [] // - .toggleSelect([1, 2, 10, 20], 'next') -- toggles items on only, returns []
@ -1974,9 +1974,6 @@ var BaseBrowserPrototype = {
// //
// Format: // Format:
// { // {
// // XXX add tagged event support...
// // ...i.e. event markers/tags that would enable the user
// // to specifically manipulate event sets....
// <event-name>: [ // <event-name>: [
// <handler>, // <handler>,
// ... // ...
@ -1984,7 +1981,10 @@ var BaseBrowserPrototype = {
// ... // ...
// } // }
// //
// XXX //
// NOTE: event handlers may have a .tag attribute that stores the tag
// it was created with, this is used by .off(..) to unbind handlers
// tagged with specific tags...
__event_handlers: null, __event_handlers: null,
// List events... // List events...
@ -2263,6 +2263,7 @@ var BaseBrowserPrototype = {
// NOTE: .update() is the same as .render() // NOTE: .update() is the same as .render()
// //
// XXX calling this on a nested browser should update the whole thing... // XXX calling this on a nested browser should update the whole thing...
// ...can we restore the context via .parent???
update: makeEventMethod('update', function(evt, full, options){ update: makeEventMethod('update', function(evt, full, options){
options = (full && full !== true && full !== false) ? options = (full && full !== true && full !== false) ?
full full
@ -2278,7 +2279,6 @@ var BaseBrowserPrototype = {
// XXX target can be item or path... // XXX target can be item or path...
load: makeEventMethod('load', function(evt, target){}), load: makeEventMethod('load', function(evt, target){}),
close: makeEventMethod('close', function(evt, reason){}), close: makeEventMethod('close', function(evt, reason){}),