mirror of
https://github.com/flynx/ImageGrid.git
synced 2025-10-28 18:00:09 +00:00
found the bug in the upstream code...
Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
parent
5b8c70f469
commit
8ee0cb3d7b
@ -1288,7 +1288,13 @@ function(spec, callback){
|
||||
// - .off(..) for some reason does not work... (CONFIRMED)
|
||||
// ...are we off-ing the right source???
|
||||
// ...one possible cause of this is that .one(..) is actually
|
||||
// binding a wrapper and not the original function -- TEST
|
||||
// binding a wrapper and not the original function -- CONFIRMED!
|
||||
// ...to reproduce:
|
||||
// var f = function(){ console.log('MOO!!!') }
|
||||
// ig.modal.client
|
||||
// .one('moo', f)
|
||||
// .off('moo', f)
|
||||
// .trigger('moo') // -> will call f(..)
|
||||
.one('update', function(){
|
||||
console.log('update:', __v)
|
||||
// XXX BUG? this.off(..) will not work with non-standard events...
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user