flynx/ImageGrid
1
1
Fork 0
mirror of https://github.com/flynx/ImageGrid.git synced 2025-10-29 18:30:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

more docs...

Browse Source 
Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
Alex A. Naanou 2020-12-25 06:00:51 +03:00
parent d2decf9eaa
commit 91bf825bc3
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
Viewer/features/core.js
View File

@ -636,6 +636,16 @@ module.Logger = ImageGridFeatures.Feature({
// this can happen for instance in ig.js when starting a minimal // this can happen for instance in ig.js when starting a minimal
// imagegrid instance and then adding new features -- these new // imagegrid instance and then adding new features -- these new
// features will not get their .start() (and friends) run... // features will not get their .start() (and friends) run...
// There are three stages here:
// - feature setup
// things the feature needs to run -- <feature>.setup(..)
// - app start
// things the app wants to do on start
// - ???
// things feature action needs to run in cli should be
// documented and not depend on .start(..)
// ...or there should be a way to "start" the new features...
// XXX put this in the docs...
// XXX should his have state??? // XXX should his have state???
// ...if so, should this be a toggler??? // ...if so, should this be a toggler???
var LifeCycleActions = actions.Actions({ var LifeCycleActions = actions.Actions({
@ -695,6 +705,7 @@ var LifeCycleActions = actions.Actions({
This will trigger .started() event when done. This will trigger .started() event when done.
NOTE: .runtime attribute will not be available on the .pre handler NOTE: .runtime attribute will not be available on the .pre handler
phase. phase.
NOTE: .requestReadyAnnounce() should be called exclusively on the NOTE: .requestReadyAnnounce() should be called exclusively on the
@ -3040,6 +3051,7 @@ var TaskActions = actions.Actions({
return link } return link }
// create a link... // create a link...
// NOTE: we intentionally disable ui here and do not trigger .start()...
link = ImageGridFeatures.setup([...this.features.input, '-ui']) link = ImageGridFeatures.setup([...this.features.input, '-ui'])
return Object.assign( return Object.assign(
link, link,