From 975b243ffd7144d2a5678d3ed88e2b4eb2fcb286 Mon Sep 17 00:00:00 2001 From: "Alex A. Naanou" Date: Sat, 26 Nov 2016 14:34:12 +0300 Subject: [PATCH] notes... Signed-off-by: Alex A. Naanou --- ui (gen4)/features/ui-single-image.js | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/ui (gen4)/features/ui-single-image.js b/ui (gen4)/features/ui-single-image.js index 59af2174..e3215609 100755 --- a/ui (gen4)/features/ui-single-image.js +++ b/ui (gen4)/features/ui-single-image.js @@ -436,16 +436,21 @@ module.SingleImageView = core.ImageGridFeatures.Feature({ core.makeWorkspaceConfigWriter( function(){ return Object.keys(this.config['single-image-config-defaults'] || {}) })], + // XXX not sure if manual calling of togglers is the right way + // to go here + it's redundant... + // ...the reasoning is that togglers can be bound to, so we + // need to call the bound code... ['loadWorkspace', core.makeWorkspaceConfigLoader( function(){ return Object.keys(this.config['single-image-config-defaults'] || {}) }, - // NOTE: considering that 'ribbon-focus-mode' is handled - // by a toggler that can have things bound to it, - // active is the way to go here... + // NOTE: options toggled by togglers are triggered here... + // XXX do not like this -- manual... function(workspace){ 'ribbon-focus-mode' in workspace && this.toggleRibbonFocusMode(workspace['ribbon-focus-mode']) + 'shifts-affect-directio' in workspace + && this.toggleShiftsAffectDirection(workspace['shifts-affect-directio']) })], ], })