mirror of
https://github.com/flynx/ImageGrid.git
synced 2025-10-29 02:10:08 +00:00
more cleanup and notes...
Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
parent
99eba83adf
commit
9ba2d231a7
@ -835,15 +835,18 @@ var BaseBrowserPrototype = {
|
|||||||
// NOTE: children arrays are handled internally...
|
// NOTE: children arrays are handled internally...
|
||||||
//
|
//
|
||||||
//
|
//
|
||||||
// XXX need to make this the same as .walk(..) from the user's
|
|
||||||
// perspective with one addition, expose the root stop(..)
|
|
||||||
// function to func...
|
|
||||||
// XXX this uses a slightly different signature to func(..) that .walk(..) does...
|
|
||||||
// XXX which of the forms should be documented in the signature???
|
// XXX which of the forms should be documented in the signature???
|
||||||
// NOTE: it does not matter which is used as we manually
|
// NOTE: it does not matter which is used as we manually
|
||||||
// parse arguments...
|
// parse arguments...
|
||||||
// XXX passing both index directly and context containing index
|
// XXX passing both index directly and context containing index
|
||||||
// (context.index) feels excessive...
|
// (context.index) feels excessive...
|
||||||
|
// + this is done so as to provide the user a simpler
|
||||||
|
// .map(..)-like form...
|
||||||
|
// Ex:
|
||||||
|
// .walk2((e, i, p, next, stop) => p.join('/'))
|
||||||
|
// // vs.
|
||||||
|
// .walk2((e, c, next, stop) => c.path.join('/'))
|
||||||
|
// - two ways to get index and one to update it...
|
||||||
// ...if this can produce errors we need to simplify...
|
// ...if this can produce errors we need to simplify...
|
||||||
// XXX add docs:
|
// XXX add docs:
|
||||||
// - maintaining context to implement/extend walkers...
|
// - maintaining context to implement/extend walkers...
|
||||||
@ -1046,8 +1049,7 @@ var BaseBrowserPrototype = {
|
|||||||
'text',
|
'text',
|
||||||
function(func, i, path, options, context){
|
function(func, i, path, options, context){
|
||||||
return [options, context] },
|
return [options, context] },
|
||||||
options,
|
options, context)
|
||||||
context)
|
|
||||||
.join('\n') },
|
.join('\n') },
|
||||||
paths: function(options, context){
|
paths: function(options, context){
|
||||||
return this.walk2(
|
return this.walk2(
|
||||||
@ -1062,8 +1064,7 @@ var BaseBrowserPrototype = {
|
|||||||
// levels we need to thread the context on, here and
|
// levels we need to thread the context on, here and
|
||||||
// into the base .walk2(..) call below...
|
// into the base .walk2(..) call below...
|
||||||
return [options, context] },
|
return [options, context] },
|
||||||
options,
|
options, context) },
|
||||||
context) },
|
|
||||||
|
|
||||||
|
|
||||||
// Extended map...
|
// Extended map...
|
||||||
@ -1135,8 +1136,7 @@ var BaseBrowserPrototype = {
|
|||||||
'map',
|
'map',
|
||||||
function(_, i, p, options, context){
|
function(_, i, p, options, context){
|
||||||
return [func, options, context] },
|
return [func, options, context] },
|
||||||
options,
|
options, context) },
|
||||||
context) },
|
|
||||||
|
|
||||||
|
|
||||||
// XXX EXPERIMENTAL...
|
// XXX EXPERIMENTAL...
|
||||||
@ -1293,7 +1293,6 @@ var BaseBrowserPrototype = {
|
|||||||
|
|
||||||
return this.walk2(
|
return this.walk2(
|
||||||
function(elem, i, path, _, stop){
|
function(elem, i, path, _, stop){
|
||||||
console.log('--', i, path.join('/'))
|
|
||||||
// match...
|
// match...
|
||||||
var res = (elem
|
var res = (elem
|
||||||
&& (test === true
|
&& (test === true
|
||||||
@ -1310,9 +1309,7 @@ var BaseBrowserPrototype = {
|
|||||||
'search',
|
'search',
|
||||||
function(_, i, p, options, context){
|
function(_, i, p, options, context){
|
||||||
return [pattern, func, options, context] },
|
return [pattern, func, options, context] },
|
||||||
options,
|
options, context) },
|
||||||
context)
|
|
||||||
},
|
|
||||||
|
|
||||||
|
|
||||||
// XXX EXPERIMENTAL...
|
// XXX EXPERIMENTAL...
|
||||||
|
|||||||
Loading…
x
Reference in New Issue
Block a user