From 9f0e59c913f98aae467a307ea9f248037e5ddf52 Mon Sep 17 00:00:00 2001 From: "Alex A. Naanou" Date: Fri, 11 Oct 2019 18:03:02 +0300 Subject: [PATCH] minor stuff + cleanup... Signed-off-by: Alex A. Naanou --- ui (gen4)/features/virtual-images.js | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/ui (gen4)/features/virtual-images.js b/ui (gen4)/features/virtual-images.js index cfa3d52e..91f88337 100644 --- a/ui (gen4)/features/virtual-images.js +++ b/ui (gen4)/features/virtual-images.js @@ -176,7 +176,6 @@ var VirtualImagesUIActions = actions.Actions({ p.call(this, image, dom) : dom }], - // XXX add text format selection... // XXX make things editable only when edit is loaded... metadataSection: [ { sortedActionPriority: 80 }, @@ -201,8 +200,18 @@ var VirtualImagesUIActions = actions.Actions({ that.refresh(gid) }, }) - // XXX add format selection... - make(['Format:', image.format || 'text']) + make(['Format:', image.format || 'text'], { + open: function(){ + this.selectTextFormat(gid) }, + }) + }], + // XXX is there a point in showing this when there is 1 format only??? + selectTextFormat: ['Virtual/Text format...', + { browseMode: function(){ + return (this.image || {}).type != 'virtual' && 'disabled' }, }, + function(gid){ + // XXX show a list of keys from __virtual_block_processors__ + // XXX }], })