From a57dbc2d7ee999e182bdfc171ad290e2595416a1 Mon Sep 17 00:00:00 2001
From: "Alex A. Naanou" <alex.nanou@gmail.com>
Date: Wed, 29 Jun 2016 20:28:38 +0300
Subject: [PATCH] fixed an issue with metadata for empty image objects...

Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
---
 ui (gen4)/features/metadata.js | 46 +++++++++++++++++++++-------------
 1 file changed, 28 insertions(+), 18 deletions(-)

diff --git a/ui (gen4)/features/metadata.js b/ui (gen4)/features/metadata.js
index 261d5634..646140e3 100755
--- a/ui (gen4)/features/metadata.js	
+++ b/ui (gen4)/features/metadata.js	
@@ -378,6 +378,7 @@ var MetadataUIActions = actions.Actions({
 				// fields that expect that image data is available...
 				var info = ['---']
 				if(img){
+					// some abstractions...
 					// XXX should these be here???
 					var _normalize = typeof(path) != 'undefined' ? 
 						path.normalize
@@ -387,28 +388,37 @@ var MetadataUIActions = actions.Actions({
 						: function(e){ return e.split(/[\\\/]/g).pop() }
 					var _dirname = typeof(path) != 'undefined' ?
 						function(e){ return path.normalize(path.dirname(e)) }
-						: function(e){ return _normalize(e.split(/[\\\/]/g).slice(0, -1).join('/')) }
+						: function(e){ 
+							return _normalize(e.split(/[\\\/]/g).slice(0, -1).join('/')) }
 
-					base = base.concat([
-						['File Name: ', 
-							_basename(img.path)],
-						['Parent Directory: ', 
-							_dirname((img.base_path || '.') +'/'+ img.path)],
-						['Full Path: ', 
-							_normalize((img.base_path || '.') +'/'+ img.path)],
+					// paths...
+					img.path 
+						&& base.push(['File Name: ', 
+							_basename(img.path)])
+						&& base.push(['Parent Directory: ', 
+							_dirname((img.base_path || '.') +'/'+ img.path)])
+						&& base.push(['Full Path: ', 
+							_normalize((img.base_path || '.') +'/'+ img.path)])
 
-						['Date created: ', img.birthtime 
-							&& new Date(img.birthtime).toShortDate()],
-						['- ctime: ', img.ctime && new Date(img.ctime).toShortDate()],
-						['- mtime: ', img.mtime && new Date(img.mtime).toShortDate()],
-						['- atime: ', img.atime && new Date(img.atime).toShortDate()],
-					])
-
-					// comment and tags...
-					info.push(['Comment: ', 
-						function(){ return img.comment || '' }]) 
+					// times...
+					img.birthtime 
+						&& base.push(['Date created: ', 
+							img.birthtime && new Date(img.birthtime).toShortDate()])
+					img.ctime
+						&& base.push(['- ctime: ', 
+							img.ctime && new Date(img.ctime).toShortDate()])
+					img.mtime
+						&& base.push(['- mtime: ',
+							img.mtime && new Date(img.mtime).toShortDate()])
+					img.atime
+						&& base.push(['- atime: ', 
+							img.atime && new Date(img.atime).toShortDate()])
 				}
 
+				// comment and tags...
+				info.push(['Comment: ', 
+					function(){ return img && img.comment || '' }]) 
+
 				info.push(['Tags: ', 
 					function(){ return that.data.getTags().join(', ') || '' }])