From a6090eef387084f7410defaeaf43241ee224c9ba Mon Sep 17 00:00:00 2001 From: "Alex A. Naanou" Date: Sat, 18 Jan 2020 05:38:22 +0300 Subject: [PATCH] notes... Signed-off-by: Alex A. Naanou --- ui (gen4)/features/ui-widgets.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/ui (gen4)/features/ui-widgets.js b/ui (gen4)/features/ui-widgets.js index ba2240f0..b5647d25 100755 --- a/ui (gen4)/features/ui-widgets.js +++ b/ui (gen4)/features/ui-widgets.js @@ -1228,7 +1228,9 @@ function(title, options){ // XXX should this also take batch options??? -// XXX need to make this handle updates correctly -- we are binding to a dialog event, need to fo this only once... +// XXX should we patch the close callback not to get called twice??? +// XXX BUG: if user passes a new spec each time this will not work... +// ...might be a good idea to bind to the element... browse.items.batch = function(spec, callback){ var that = this @@ -1273,7 +1275,8 @@ function(spec, callback){ spec, // XXX is this the right spot for this??? mode) }) - // XXX is this a good way to do this??? + // XXX BUG: if user passes a new spec each time this will not work... + // ...might be a good idea to bind to the element... spec.__batch_setup = true return this }