From 10963955092ed3cf7c08c2b074044d7a297f136c Mon Sep 17 00:00:00 2001 From: "Alex A. Naanou" Date: Thu, 14 Jan 2021 23:52:37 +0300 Subject: [PATCH 1/3] notes... Signed-off-by: Alex A. Naanou --- Viewer/features/core.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Viewer/features/core.js b/Viewer/features/core.js index 85bb8f44..f855ccb5 100755 --- a/Viewer/features/core.js +++ b/Viewer/features/core.js @@ -2725,7 +2725,8 @@ function(title, func){ // // XXX might be a good idea to split this into a generic and domain parts // and move the generic part into types/runner... -// XXX check if item is already in queue... +// XXX check if item is already in queue (???) +// ...how do we identify item uniqueness?? var queueHandler = module.queueHandler = function(title, func){ From 492f98b78d3e3c4383cc309b1384809f6eee3043 Mon Sep 17 00:00:00 2001 From: "Alex A. Naanou" Date: Fri, 15 Jan 2021 23:21:02 +0300 Subject: [PATCH 2/3] cleanup... Signed-off-by: Alex A. Naanou --- Viewer/features/sharp.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/Viewer/features/sharp.js b/Viewer/features/sharp.js index 2c9e19ce..6ce0082f 100755 --- a/Viewer/features/sharp.js +++ b/Viewer/features/sharp.js @@ -700,10 +700,6 @@ var SharpActions = actions.Actions({ && logger.emit('skipped', `${gid} / ${size}`) }) })) })], - // XXX BUG: .cacheMetadata('all'): runs out of call stack on very - // large indexes... - // ...can't yet see/find any recursion... - // .....at least the fail is fast and quiet =) // XXX add support for offloading the processing to a thread/worker... // XXX revise logging and logger passing... cacheMetadata: ['- Sharp|Image/', From 0bb281c7ddead23959853d5b5cda37cc57e95f61 Mon Sep 17 00:00:00 2001 From: "Alex A. Naanou" Date: Sat, 16 Jan 2021 13:11:48 +0300 Subject: [PATCH 3/3] cleanup... Signed-off-by: Alex A. Naanou --- Viewer/features/sharp.js | 1 - 1 file changed, 1 deletion(-) diff --git a/Viewer/features/sharp.js b/Viewer/features/sharp.js index 6ce0082f..8a764882 100755 --- a/Viewer/features/sharp.js +++ b/Viewer/features/sharp.js @@ -422,7 +422,6 @@ var SharpActions = actions.Actions({ // XXX should we split this into a session and global versions // a-la .makeResizedImage(..)??? // XXX this does not update image.base_path -- is this correct??? - // XXX add support for offloading the processing to a thread/worker... // XXX make index dir hidden... makePreviews: ['Sharp|File/Make image $previews', core.doc`Make image previews