From a953a3817c6e1d3646ca1a224b25a71aa94cd6ad Mon Sep 17 00:00:00 2001 From: "Alex A. Naanou" Date: Thu, 17 Aug 2017 16:41:56 +0300 Subject: [PATCH] notes Signed-off-by: Alex A. Naanou --- ui (gen4)/features/alias.js | 9 +++------ ui (gen4)/lib/widget/browse.js | 4 ++++ 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/ui (gen4)/features/alias.js b/ui (gen4)/features/alias.js index ce0defa3..988ba1d8 100755 --- a/ui (gen4)/features/alias.js +++ b/ui (gen4)/features/alias.js @@ -108,9 +108,10 @@ module.Alias = core.ImageGridFeatures.Feature({ //--------------------------------------------------------------------- var UIAliasActions = actions.Actions({ - // XXX should this update the parent??? - // XXX updating this does not work yet... browseAliases: ['System/Aliases...', + core.doc`Action alias list + + NOTE: this may affect the action menu, to see changes update the menu.`, widgets.makeUIDialog(function(){ var that = this @@ -129,10 +130,7 @@ var UIAliasActions = actions.Actions({ var names = Object.keys(aliases) - console.log('>>>>>>>>>>>', names) - names.length > 0 ? - // XXX for some reason this does not get updated on dialog.update() make.EditableList(names, { new_item: false, @@ -145,7 +143,6 @@ var UIAliasActions = actions.Actions({ }, each: function(name, elem){ - console.log('>>>>', name) $(elem) .attr({ keys: getKeys(name), diff --git a/ui (gen4)/lib/widget/browse.js b/ui (gen4)/lib/widget/browse.js index 2ee76577..818cac1c 100755 --- a/ui (gen4)/lib/widget/browse.js +++ b/ui (gen4)/lib/widget/browse.js @@ -668,6 +668,10 @@ function(data, options){ // NOTE: the list must contain strings. // // XXX should id be the first argument?? +// XXX TEST: potential problem: when reloading the list this will +// overwrite the .__list[id] cache, with the input list, this may +// result in losing the edited state if the lists were not synced +// properly... Items.EditableList = function(list, options){ var make = this