flynx/ImageGrid
1
1
Fork 0
mirror of https://github.com/flynx/ImageGrid.git synced 2025-10-30 02:40:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactoring and experimenting...

Browse Source 
Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
Alex A. Naanou 2020-01-15 02:31:55 +03:00
parent 487eb5c167
commit b162bbacb0
2 changed files with 115 additions and 119 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
ui (gen4)/features/examples.js
View File

@ -946,15 +946,15 @@ var ExampleUIActions = actions.Actions({
{title: 'foo', value: 123}, {title: 'foo', value: 123},
{type: 'field.Toggle', title: 'Batch toggle 1: '}, {type: 'field.Toggle', title: 'Batch toggle 1: '},
]) ])
make.field.batch(b2 = b2 || [ make.field.batch(
b2 = b2 || [
'---', '---',
['X', 'Y'], ['X', 'Y'],
{type: 'Toggle', title: 'foo', values: ['1','2','3'], list: false}, {type: 'Toggle', title: 'foo', values: ['1','2','3'], list: false},
{type: 'Toggle', title: 'Batch toggle 2: '}, {type: 'Toggle', title: 'Batch toggle 2: '},
], function(){ ],
console.log('---', ...arguments) function(){
}) console.log('-- (2nd batch) --', ...arguments) })
}, { }, {
cls: 'table-view', cls: 'table-view',
}) })], }) })],

22
ui (gen4)/features/ui-widgets.js
View File

@ -1045,7 +1045,6 @@ browse.items.makeSubContext = function(name, obj){
// ...this can be problematic as the wrapper is external to the browser... // ...this can be problematic as the wrapper is external to the browser...
// - as a sub-path... // - as a sub-path...
// ...this is hard without side-effects... // ...this is hard without side-effects...
// XXX need to make this handle updates correctly...
browse.items.makeSubContext('field', browse.items.makeSubContext('field',
function(title, value, options){ function(title, value, options){
// parse arguments... // parse arguments...
@ -1087,6 +1086,10 @@ browse.items.makeSubContext('field',
// - a way to define defaults -- global options? // - a way to define defaults -- global options?
// - access to the .app -- should be configurable... // - access to the .app -- should be configurable...
// - default methods .showEditableList(..) / .showList(..) on make(..) // - default methods .showEditableList(..) / .showList(..) on make(..)
// XXX currently if a user defines options.open it will fully override
// the default open behavior...
// ...need a way to deal with this, preferably automatically...
// ......test!
browse.items.field.Toggle = browse.items.field.Toggle =
function(title, options){ function(title, options){
var that = this var that = this
@ -1099,9 +1102,9 @@ function(title, options){
: args.shift() : args.shift()
options = args.shift() || {} options = args.shift() || {}
var open = options.open return this.field(title, value,
var toggler_defaults = Object.assign(
// only setup once... options,
options.__toggle_setup ? options.__toggle_setup ?
{} {}
: { : {
@ -1111,9 +1114,6 @@ function(title, options){
//type: options.type || 'toggle', //type: options.type || 'toggle',
open: function(evt){ open: function(evt){
open
&& open.call(this, ...arguments)
// XXX CONTEXT... // XXX CONTEXT...
var actions = options.app || that.app var actions = options.app || that.app
@ -1205,12 +1205,7 @@ function(title, options){
} else { } else {
// XXX should we be able to toggle values back??? // XXX should we be able to toggle values back???
set(values[(values.indexOf(current) + 1) % values.length]) } set(values[(values.indexOf(current) + 1) % values.length]) }
} } } },
return this.field(title, value,
Object.assign(
options,
toggler_defaults,
options options
// normalize value... // normalize value...
.run(function(){ .run(function(){
@ -1234,6 +1229,7 @@ function(title, options){
// XXX should this also take batch options??? // XXX should this also take batch options???
// XXX close event is sometimes triggered twice...
browse.items.batch = browse.items.batch =
function(spec, callback){ function(spec, callback){
var that = this var that = this