flynx/ImageGrid
1
1
Fork 0
mirror of https://github.com/flynx/ImageGrid.git synced 2025-10-30 19:00:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

documented some pitfalls...

Browse Source 
Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
Alex A. Naanou 2014-03-22 17:24:44 +04:00
parent b1d97daa6a
commit ba266f594b
1 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
ui/data4.js
View File

@ -753,8 +753,13 @@ var DataPrototype = {
// NOTE: .getImage(..) defaults to 'before' thus this to defaults // NOTE: .getImage(..) defaults to 'before' thus this to defaults
// to 'after' // to 'after'
// //
// XXX ribbon position range checking... // XXX check for corner cases:
// XXX ribbon order range checking... // - first/last in ribbon offset
// - first/last in order offset
// - first/last ribbon up/down
// do we create new ribbons and round???
// XXX when shifting groups of images we are using the first as a
// base, should we use last as a base for right shifting???
// XXX process from as a list of gids... // XXX process from as a list of gids...
// XXX test vertical.. // XXX test vertical..
shiftImage: function(from, target, mode){ shiftImage: function(from, target, mode){
@ -770,6 +775,8 @@ var DataPrototype = {
// target is an offset... // target is an offset...
if(mode == 'offset'){ if(mode == 'offset'){
// XXX change check this...
// XXX check that we can place an elem at first and last positions...
var t = this.getImageOrder(this.getImage(first, target)) var t = this.getImageOrder(this.getImage(first, target))
var ribbon = this.getRibbon(first) var ribbon = this.getRibbon(first)
@ -779,6 +786,11 @@ var DataPrototype = {
} else if(typeof(target) == typeof(123)){ } else if(typeof(target) == typeof(123)){
var t = f var t = f
// normalize the target...
// XXX is this the correct way to go???
target = Math.max(0, target)
target = Math.min(this.ribbon_order-1, target)
var ribbon = this.ribbon_order[target] var ribbon = this.ribbon_order[target]
// target is a ribbon gid... // target is a ribbon gid...
@ -799,6 +811,7 @@ var DataPrototype = {
var from_ribbon = this.getRibbon(first) var from_ribbon = this.getRibbon(first)
// do vertical shift... // do vertical shift...
// XXX do we create new ribbons here???
if(ribbon != from_ribbon || from.length > 1){ if(ribbon != from_ribbon || from.length > 1){
var that = this var that = this
from.forEach(function(e){ from.forEach(function(e){