minor bugfixes...

Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
Alex A. Naanou 2017-12-30 02:31:03 +03:00
parent a94cffa212
commit c428d9c4dc

View File

@ -133,6 +133,7 @@ module.ExternalEditor = core.ImageGridFeatures.Feature({
var ExternalEditorUIActions = actions.Actions({ var ExternalEditorUIActions = actions.Actions({
// XXX empty title -- use app name without ext... // XXX empty title -- use app name without ext...
// XXX update to new dialog API...
externalEditorDialog: ['- Edit/', externalEditorDialog: ['- Edit/',
widgets.makeUIDialog(function(editor){ widgets.makeUIDialog(function(editor){
var that = this var that = this
@ -213,7 +214,8 @@ var ExternalEditorUIActions = actions.Actions({
return editor.target return editor.target
|| that.config['external-editor-targets'][0] }]) || that.config['external-editor-targets'][0] }])
.on('open', .on('open',
widgets.makeNestedConfigListEditor(that, dialog.parent, //widgets.makeNestedConfigListEditor(that, dialog.parent,
widgets.makeNestedConfigListEditor(that, make.dialog.parent,
'external-editor-targets', 'external-editor-targets',
function(val){ function(val){
if(val == null){ if(val == null){
@ -302,7 +304,7 @@ var ExternalEditorUIActions = actions.Actions({
editors.push({ editors.push({
path: path, path: path,
}) })
that.config['external-editors'] = editors that.config['external-editors'] = editors.slice()
// is this the correct way to do this??? // is this the correct way to do this???
b.close() b.close()
@ -338,7 +340,7 @@ var ExternalEditorUIActions = actions.Actions({
target.before(cur) target.before(cur)
editors.splice(0, 0, editors.splice(i, 1)[0]) editors.splice(0, 0, editors.splice(i, 1)[0])
that.config['external-editors'] = editors that.config['external-editors'] = editors.slice()
} }
}], }],
// set secondary editor... // set secondary editor...
@ -358,7 +360,7 @@ var ExternalEditorUIActions = actions.Actions({
} }
editors.splice(1, 0, editors.splice(i, 1)[0]) editors.splice(1, 0, editors.splice(i, 1)[0])
that.config['external-editors'] = editors that.config['external-editors'] = editors.slice()
} }
}], }],
// mark for removal... // mark for removal...
@ -398,7 +400,7 @@ var ExternalEditorUIActions = actions.Actions({
} }
editors.splice(_getEditor(e), 1) editors.splice(_getEditor(e), 1)
that.config['external-editors'] = editors that.config['external-editors'] = editors.slice()
}) })
}) })