From 1222f147405fc03579f812ac2d3cb54dd16c5f15 Mon Sep 17 00:00:00 2001 From: "Alex A. Naanou" Date: Sun, 20 Feb 2022 12:19:44 +0300 Subject: [PATCH 1/3] notes... Signed-off-by: Alex A. Naanou --- Viewer/features/core.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Viewer/features/core.js b/Viewer/features/core.js index d8dd5913..f408e2cf 100755 --- a/Viewer/features/core.js +++ b/Viewer/features/core.js @@ -1950,7 +1950,7 @@ var JournalActions = actions.Actions({ // for format docs see: .updateJournalableActions(..) journal: null, rjournal: null, - + // XXX make this a cached prop... journalable: null, // XXX docs... From 8488a4f12675cdf088e140363c094c8c65ef883d Mon Sep 17 00:00:00 2001 From: "Alex A. Naanou" Date: Sun, 20 Feb 2022 12:39:36 +0300 Subject: [PATCH 2/3] more notes... Signed-off-by: Alex A. Naanou --- Viewer/features/core.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Viewer/features/core.js b/Viewer/features/core.js index f408e2cf..aa5070ea 100755 --- a/Viewer/features/core.js +++ b/Viewer/features/core.js @@ -2041,7 +2041,7 @@ var JournalActions = actions.Actions({ .map(function(action){ that.on(action+'.pre', 'journal-handler', handler(action)) return action }) }], - + // XXX unify names (globally) -> .journal(..) or .Journal(..) journalPush: ['- System/Journal/Add an item to journal', function(data){ // clear the reverse journal... From 3888a5079acede353fbb93e156dd3e224c187b5e Mon Sep 17 00:00:00 2001 From: "Alex A. Naanou" Date: Sun, 20 Feb 2022 12:51:06 +0300 Subject: [PATCH 3/3] minor fix... Signed-off-by: Alex A. Naanou --- Viewer/features/core.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Viewer/features/core.js b/Viewer/features/core.js index aa5070ea..92c5b9ab 100755 --- a/Viewer/features/core.js +++ b/Viewer/features/core.js @@ -2265,8 +2265,8 @@ module.Journal = ImageGridFeatures.Feature({ // XXX is this a good idea??? ['load clear', function(){ - delete this.journal - delete this.rjournal }], + this.clearJournal() }], + // log saved event to journal... ['saved', function(res, ...args){