fixed a fix and added a comment so as not to fix it again...

Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
Alex A. Naanou 2017-01-28 01:49:08 +03:00
parent 7551604d77
commit c843eb1da4

View File

@ -1164,7 +1164,7 @@ var BrowserPrototype = {
// NOTE: recommended values are about the same value till the // NOTE: recommended values are about the same value till the
// first make(..) is called, but obviously this should be // first make(..) is called, but obviously this should be
// as short as possible -- under 20-50ms. // as short as possible -- under 20-50ms.
holdSize: 10, holdSize: 20,
}, },
// XXX TEST: this should prevent event propagation... // XXX TEST: this should prevent event propagation...
@ -1972,7 +1972,12 @@ var BrowserPrototype = {
.click(function(){ .click(function(){
!$(this).hasClass('disabled') !$(this).hasClass('disabled')
&& that.push($(this)) }) && that.push($(this)) })
.addClass([ // append text elements...
.append(p)
// NOTE: this is not done inline because we need access to
// res below...
res.addClass([
'item', 'item',
// XXX use the same algorithm as .select(..) // XXX use the same algorithm as .select(..)
selection && res.text() == selection ? 'selected' : '', selection && res.text() == selection ? 'selected' : '',
@ -1984,8 +1989,6 @@ var BrowserPrototype = {
(opts.hide_on_search || opts.not_searchable) ? 'not-searchable' : '', (opts.hide_on_search || opts.not_searchable) ? 'not-searchable' : '',
opts.not_filtered_out ? 'not-filtered-out' : '', opts.not_filtered_out ? 'not-filtered-out' : '',
].join(' ')) ].join(' '))
// append text elements...
.append(p)
opts.push_on_open opts.push_on_open
&& res.attr('push-on-open', 'on') && res.attr('push-on-open', 'on')