flynx/ImageGrid
1
1
Fork 0
mirror of https://github.com/flynx/ImageGrid.git synced 2025-10-30 10:50:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

minor changes to todo (documented a race bug) and docs...

Browse Source 
Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
Alex A. Naanou 2013-08-13 18:15:48 +04:00
parent 5e7fafd9c5
commit c87a957d8c
3 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ui/TODO.otl
View File

@ -97,6 +97,8 @@ Roadmap
[_] 59% High priority [_] 59% High priority
[_] add indicator to ribbon up/down navigation in full screen... [_] add indicator to ribbon up/down navigation in full screen...
| this might be a number or some kind of animation... | this might be a number or some kind of animation...
[_] BUG: sometimes opening a dir (open dialog) does not do anything...
| Uncaught TypeError: Cannot call method 'indexOf' of undefined -- data.js:576
[_] BUG: sometimes images.json folder is created... [_] BUG: sometimes images.json folder is created...
[_] rework the marks.js/modes.js to enable multi-level cropping... [_] rework the marks.js/modes.js to enable multi-level cropping...
[_] 0% Priority tasks [_] 0% Priority tasks

5
ui/data.js
View File

@ -551,11 +551,16 @@ function getGIDBefore(gid, ribbon, search){
// correct ribbon number... // correct ribbon number...
// //
// XXX do we need more checking??? // XXX do we need more checking???
// XXX Race condition: when this is called while DATA is not yet fully
// loaded (old data), the from gid will not be present in
// DATA.ribbons...
function getImageGIDs(from, count, ribbon, inclusive){ function getImageGIDs(from, count, ribbon, inclusive){
if(count == 0){ if(count == 0){
return [] return []
} }
// ribbon default value... // ribbon default value...
// XXX Race condition: if DATA is not yet loaded this can return
// ribbon == null...
if(ribbon == null){ if(ribbon == null){
$(DATA.ribbons).each(function(i, e){ $(DATA.ribbons).each(function(i, e){
if(e.indexOf(from) >= 0){ if(e.indexOf(from) >= 0){

3
ui/layout.css
View File

@ -454,6 +454,9 @@ button:hover {
right: 5px; right: 5px;
border-radius: 50%; border-radius: 50%;
background: blue; background: blue;
/* make the mark stand out if it is over an image with similar
color/density */
box-shadow: 0px 0px 7px 0px black; box-shadow: 0px 0px 7px 0px black;
/*border: solid 1px white;*/ /*border: solid 1px white;*/