flynx/ImageGrid
1
1
Fork 0
mirror of https://github.com/flynx/ImageGrid.git synced 2025-10-29 10:20:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

cleanup and notes/docs...

Browse Source 
Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
Alex A. Naanou 2019-12-24 19:39:33 +03:00
parent 6e4c8e18d5
commit ca6253115c
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
ui (gen4)/features/ui-widgets.js
View File

@ -1030,6 +1030,10 @@ browse.items.makeSubContext = function(name, obj){
// .field(title, value[, options]) // .field(title, value[, options])
// //
// //
// NOTE: essentially make.field(..) is almost identical to make(..), the
// later is needed to provide context for field items and a transparent
// fallback for make(..) calls from within their context...
//
// XXX Q: should we add an ImageGrid context to make(..)??? // XXX Q: should we add an ImageGrid context to make(..)???
// ...something like .app for making it generic-ish for example... // ...something like .app for making it generic-ish for example...
// ....a different approach to this would be to create a list editor // ....a different approach to this would be to create a list editor
@ -1039,11 +1043,6 @@ browse.items.makeSubContext = function(name, obj){
// ...this can be problematic as the wrapper is external to the browser... // ...this can be problematic as the wrapper is external to the browser...
// - as a sub-path... // - as a sub-path...
// ...this is hard without side-effects... // ...this is hard without side-effects...
// XXX Q: do we actually need .field(..), it does everything make(..)
// does already???
// XXX Q: should title/value args be optional???
// ...and should we break the make(..) convention of passing an arg
// array for multiple .text blocks, i.e. make([title, value], ...)??
browse.items.makeSubContext('field', browse.items.makeSubContext('field',
function(title, value, options){ function(title, value, options){
// parse arguments... // parse arguments...