mirror of
https://github.com/flynx/ImageGrid.git
synced 2025-10-29 02:10:08 +00:00
more notes...
Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
parent
786fc542ea
commit
d793b03134
@ -232,6 +232,7 @@ var makeEventMethod = function(event, handler){
|
|||||||
// callItemEventHandlers(item, event_name, event_object, ...)
|
// callItemEventHandlers(item, event_name, event_object, ...)
|
||||||
// -> null
|
// -> null
|
||||||
//
|
//
|
||||||
|
// XXX should this call item.parent.trigger(..) ???
|
||||||
var callItemEventHandlers = function(item, event, evt, ...args){
|
var callItemEventHandlers = function(item, event, evt, ...args){
|
||||||
;(item[event] ?
|
;(item[event] ?
|
||||||
[item[event]]
|
[item[event]]
|
||||||
@ -267,6 +268,9 @@ var callItemEventHandlers = function(item, event, evt, ...args){
|
|||||||
// events may get triggered more than once...
|
// events may get triggered more than once...
|
||||||
// - we can not rely on full bottom/up propagation as some
|
// - we can not rely on full bottom/up propagation as some
|
||||||
// containers in the path may be basic Arrays...
|
// containers in the path may be basic Arrays...
|
||||||
|
// - need to make this work with .trigger(..) for non-item events
|
||||||
|
// i.e. currently .trigger(..) propagates the event to parent and
|
||||||
|
// this may conflict with us triggering events on the path...
|
||||||
var makeItemEventMethod = function(event, handler, options){
|
var makeItemEventMethod = function(event, handler, options){
|
||||||
options = Object.assign(
|
options = Object.assign(
|
||||||
// NOTE: we need to be able to pass item objects, so we can not
|
// NOTE: we need to be able to pass item objects, so we can not
|
||||||
|
|||||||
Loading…
x
Reference in New Issue
Block a user