flynx/ImageGrid
1
1
Fork 0
mirror of https://github.com/flynx/ImageGrid.git synced 2025-10-29 10:20:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

some tweaks...

Browse Source 
Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
Alex A. Naanou 2019-03-06 22:13:07 +03:00
commit da4946b2fc
1 changed files with 25 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
ui (gen4)/lib/widget/browse2.js
View File

@ -256,7 +256,9 @@ var BaseBrowserPrototype = {
noDuplicateValues: false, noDuplicateValues: false,
}, },
// XXX needed to bubble the events up... // parent widget object...
//
// NOTE: this may or may not be a Browser object.
parent: null, parent: null,
// //
@ -275,7 +277,7 @@ var BaseBrowserPrototype = {
// //
// NOTE: this can't be a map/dict as we need both order manipulation // NOTE: this can't be a map/dict as we need both order manipulation
// and nested structures which would overcomplicate things, as // and nested structures which would overcomplicate things, as
// a compromise we use .item_index blow for item identification. // a compromise we use .item_index below for item identification.
__items: null, __items: null,
get items(){ get items(){
this.__items this.__items
@ -291,12 +293,27 @@ var BaseBrowserPrototype = {
// ... // ...
// } // }
// //
// NOTE: this will get overwritten each tume .make(..) is called.
//
// XXX need to maintain this over item add/remove/change... // XXX need to maintain this over item add/remove/change...
// XXX Q: should we be able to add/remove/change items outside of .__list__(..)??? // XXX Q: should we be able to add/remove/change items outside of .__list__(..)???
// ...only some item updates (how .collapsed is handled) make // ...only some item updates (how .collapsed is handled) make
// sense at this time -- need to think about this more // sense at this time -- need to think about this more
// carefully + strictly document the result... // carefully + strictly document the result...
item_index: null, // XXX can we make the format here simpler with less level
// of indirection??
// ...currently to go down a path we need to:
// this.item_index.A.sublist.item_index.B.sublist...
// would be nice to be closer to:
// this.A.B...
__item_index: null,
get item_index(){
this.__item_index
|| this.make()
return this.__item_index },
set item_index(value){
this.__item_index = value },
// XXX what should these return??? (item, id, ...) // XXX what should these return??? (item, id, ...)
__focused: undefined, __focused: undefined,
@ -378,8 +395,7 @@ var BaseBrowserPrototype = {
//return JSON.stringify(key) //return JSON.stringify(key)
return key instanceof Array ? return key instanceof Array ?
key.join(' ') key.join(' ')
: key : key },
},
// Key getter/generator... // Key getter/generator...
// //
@ -413,7 +429,7 @@ var BaseBrowserPrototype = {
// Make .items... // Make .items and .item_index...
// //
// .make() // .make()
// .make(options) // .make(options)
@ -436,8 +452,8 @@ var BaseBrowserPrototype = {
options = options || this.options || {} options = options || this.options || {}
var items = this.items = [] var items = this.items = []
var old_index = this.item_index || {} var old_index = this.__item_index || {}
var new_index = this.item_index = {} var new_index = this.__item_index = {}
// item constructor... // item constructor...
// //
@ -682,6 +698,7 @@ var BaseBrowserPrototype = {
// -> item // -> item
// -> undefined // -> undefined
// //
// XXX add path support...
get: function(key){ get: function(key){
key = key == null ? 0 : key key = key == null ? 0 : key